bdinfo: sh: arc: Drop arch-specific print_bi_mem()
authorSimon Glass <sjg@chromium.org>
Sun, 10 May 2020 20:16:47 +0000 (14:16 -0600)
committerTom Rini <trini@konsulko.com>
Thu, 25 Jun 2020 17:24:12 +0000 (13:24 -0400)
It isn't worth having arch-specific code for such minor output
differences. In fact it is better if all archs are consistent.

Drop the arch-specific code in print_bi_mem() and inline it to avoid a
two-line function.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
Acked-by: Alexey Brodkin <abrodkin@synopsys.com>
cmd/bdinfo.c

index 60bfb4e1da9dce883cae4a2345bcc0772ccd337c..9746433c23b1c40936642cfcceef1a238965fbd3 100644 (file)
@@ -80,20 +80,6 @@ static void print_bi_boot_params(const bd_t *bd)
        print_num("boot_params",        (ulong)bd->bi_boot_params);
 }
 
-static void print_bi_mem(const bd_t *bd)
-{
-#if defined(CONFIG_SH)
-       print_num("mem start      ",    (ulong)bd->bi_memstart);
-       print_lnum("mem size       ",   (u64)bd->bi_memsize);
-#elif defined(CONFIG_ARC)
-       print_num("mem start",          (ulong)bd->bi_memstart);
-       print_lnum("mem size",          (u64)bd->bi_memsize);
-#else
-       print_num("memstart",           (ulong)bd->bi_memstart);
-       print_lnum("memsize",           (u64)bd->bi_memsize);
-#endif
-}
-
 static void print_bi_dram(const bd_t *bd)
 {
 #ifdef CONFIG_NR_DRAM_BANKS
@@ -155,7 +141,8 @@ int do_bdinfo(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
                print_num("arch_number", bd->bi_arch_number);
        print_bi_boot_params(bd);
        print_bi_dram(bd);
-       print_bi_mem(bd);
+       print_num("memstart", (ulong)bd->bi_memstart);
+       print_lnum("memsize", (u64)bd->bi_memsize);
        print_bi_flash(bd);
        print_eth_ip_addr();
        printf("baudrate    = %u bps\n", gd->baudrate);