Fix some clang warnings

Clang was complaining about some unused functions. Moving the stack
declaration to the header seems to sort it. Also the certstatus variable
in dtlstest needed to be declared static.

Reviewed-by: Richard Levitte <levitte@openssl.org>

diff --git a/test/dtlstest.c b/test/dtlstest.c
index 06db5d28bd7e3c7c4f60e6bc8af3906afbb5f80e..4d497af1afe9e849126351f21c9bccf918528842 100644 (file)
--- a/test/dtlstest.c
+++ b/test/dtlstest.c
@@ -23,7 +23,7 @@ static char *privkey = NULL;
 
 #define DUMMY_CERT_STATUS_LEN  12
 
-unsigned char certstatus[] = {
+static unsigned char certstatus[] = {
     SSL3_RT_HANDSHAKE, /* Content type */
     0xfe, 0xfd, /* Record version */
     0, 1, /* Epoch */

diff --git a/test/ssltestlib.c b/test/ssltestlib.c
index a6ca5ffa905f41d13d446ed3667293c28eea41b4..ff5cbedd6d61f327402f8b3115a86a2d27046d6d 100644 (file)
--- a/test/ssltestlib.c
+++ b/test/ssltestlib.c
@@ -238,8 +238,6 @@ typedef struct mempacket_st {
     unsigned int type;
 } MEMPACKET;
 
-DEFINE_STACK_OF(MEMPACKET)
-
 static void mempacket_free(MEMPACKET *pkt)
 {
     if (pkt->data != NULL)

diff --git a/test/ssltestlib.h b/test/ssltestlib.h
index 27f7547751d0e003336702a2602177dcffc38af3..bd9272f1dcbbb2aeb25d70d7d46c8510db8b0584 100644 (file)
--- a/test/ssltestlib.h
+++ b/test/ssltestlib.h
@@ -33,4 +33,8 @@ void bio_s_mempacket_test_free(void);
 int mempacket_test_inject(BIO *bio, const char *in, int inl, int pktnum,
                           int type);
 
+typedef struct mempacket_st MEMPACKET;
+
+DEFINE_STACK_OF(MEMPACKET)
+
 #endif /* HEADER_SSLTESTLIB_H */