utils: Refactor check_id out of protocol for global access

diff --git a/src/info.c b/src/info.c
index af085bc3633cbd73857dfb672c723a6ac5e11f76..c9b0094699b8d5add60e72e8a9d3d63caacef564 100644 (file)
--- a/src/info.c
+++ b/src/info.c
@@ -24,6 +24,7 @@
 #include "subnet.h"
 #include "tincctl.h"
 #include "info.h"
+#include "utils.h"
 #include "xalloc.h"
 
 void logger(int level, int priority, const char *format, ...) {

diff --git a/src/protocol.c b/src/protocol.c
index 374c52299fe8d7d9bd84739cf26ba43d3f75f307..1ec169a00d223a084f4d5deae951a2ec402bf865 100644 (file)
--- a/src/protocol.c
+++ b/src/protocol.c
@@ -55,17 +55,6 @@ static char (*request_name[]) = {
 
 static splay_tree_t *past_request_tree;
 
-bool check_id(const char *id) {
-       if(!id || !*id)
-               return false;
-
-       for(; *id; id++)
-               if(!isalnum(*id) && *id != '_')
-                       return false;
-
-       return true;
-}
-
 /* Generic request routines - takes care of logging and error
    detection as well */
 

diff --git a/src/protocol.h b/src/protocol.h
index e771c545c5b398b49ef6eb3b175d9406093636a1..1a1fb3f8cc0207ab0e884e24f76039db10f2efe0 100644 (file)
--- a/src/protocol.h
+++ b/src/protocol.h
@@ -81,7 +81,6 @@ extern ecdsa_t *invitation_key;
 extern bool send_request(struct connection_t *, const char *, ...) __attribute__ ((__format__(printf, 2, 3)));
 extern void forward_request(struct connection_t *, const char *);
 extern bool receive_request(struct connection_t *, const char *);
-extern bool check_id(const char *);
 
 extern void init_requests(void);
 extern void exit_requests(void);

diff --git a/src/tincctl.c b/src/tincctl.c
index 2a2c488e8fd712296a5546b4124408b2d20f1511..158dfed89acd3201d0b1d2084565500ffa3a0b2e 100644 (file)
--- a/src/tincctl.c
+++ b/src/tincctl.c
@@ -1675,18 +1675,6 @@ static int cmd_config(int argc, char *argv[]) {
        return 0;
 }
 
-bool check_id(const char *name) {
-       if(!name || !*name)
-               return false;
-
-       for(int i = 0; i < strlen(name); i++) {
-               if(!isalnum(name[i]) && name[i] != '_')
-                       return false;
-       }
-
-       return true;
-}
-
 static bool try_bind(int port) {
        struct addrinfo *ai = NULL;
        struct addrinfo hint = {

diff --git a/src/utils.c b/src/utils.c
index 797bc3f51540f00771a4275af9c47d4f58a7ace0..db7a8cd631949d41e2ba4a73af9b91af2d8ecf92 100644 (file)
--- a/src/utils.c
+++ b/src/utils.c
@@ -181,6 +181,17 @@ unsigned int bitfield_to_int(const void *bitfield, size_t size) {
        return value;
 }
 
+bool check_id(const char *id) {
+       if(!id || !*id)
+               return false;
+
+       for(; *id; id++)
+               if(!isalnum(*id) && *id != '_')
+                       return false;
+
+       return true;
+}
+
 char *replace_name(const char *name) {
        char *ret_name;
 

diff --git a/src/utils.h b/src/utils.h
index 28afc4ef81ec42ef5407749c56fdcb21c23d5c1d..c3364ced9200028f6727ff309ee624fcb94f1406 100644 (file)
--- a/src/utils.h
+++ b/src/utils.h
@@ -50,6 +50,7 @@ extern const char *winerror(int);
 
 extern unsigned int bitfield_to_int(const void *bitfield, size_t size);
 
+extern bool check_id(const char *);
 char *replace_name(const char *name);
 
 #endif /* __TINC_UTILS_H__ */