smsc95xx: Fix MAC address programming
authorWolfgang Grandegger <wg@denx.de>
Mon, 14 Nov 2011 23:19:14 +0000 (23:19 +0000)
committerStefano Babic <sbabic@denx.de>
Tue, 22 Nov 2011 07:39:24 +0000 (08:39 +0100)
Commit 79ad54400932d6484178a372fb3b659e3437473b broke MAC address
programming in the SMSC95xx register set.

Cc: Marek Vasut <marek.vasut@gmail.com>
Cc: Wolfgang Denk <wd@denx.de>
Cc: Simon Glass <sjg@chromium.org>
Cc: Mike Frysinger <vapier@gentoo.org>
Signed-off-by: Wolfgang Grandegger <wg@denx.de>
Acked-by: Mike Frysinger <vapier@gentoo.org>
Acked-by: Simon Glass <sjg@chromium.org>
drivers/usb/eth/smsc95xx.c

index 7ee4f87eaa97baf4169a39f36d3faf5176080977..b5626e65f3ab4f97a6dc9a2f86727fc42bd6ef06 100644 (file)
@@ -20,6 +20,7 @@
  * MA 02111-1307 USA
  */
 
+#include <asm/unaligned.h>
 #include <common.h>
 #include <usb.h>
 #include <linux/mii.h>
@@ -372,13 +373,12 @@ static int smsc95xx_init_mac_address(struct eth_device *eth,
 static int smsc95xx_write_hwaddr(struct eth_device *eth)
 {
        struct ueth_data *dev = (struct ueth_data *)eth->priv;
-       u32 addr_lo, addr_hi;
+       u32 addr_lo = __get_unaligned_le32(&eth->enetaddr[0]);
+       u32 addr_hi = __get_unaligned_le16(&eth->enetaddr[4]);
        int ret;
 
        /* set hardware address */
        debug("** %s()\n", __func__);
-       addr_lo = cpu_to_le32(*eth->enetaddr);
-       addr_hi = cpu_to_le16(*((u16 *)(eth->enetaddr + 4)));
        ret = smsc95xx_write_reg(dev, ADDRL, addr_lo);
        if (ret < 0) {
                debug("Failed to write ADDRL: %d\n", ret);