Revert a const ref on update texture

if mod is a reference to a class member a variable swap breaks.
We should find a way to keep this const ref if possible.
Added a comment about this in header

diff --git a/src/content_cao.cpp b/src/content_cao.cpp
index 3aa3bad97094c95e883d73a440ca324fec6b22a3..2a4acd37344a4ff0ae092323e7998932ee864ffd 100644 (file)
--- a/src/content_cao.cpp
+++ b/src/content_cao.cpp
@@ -1313,7 +1313,7 @@ void GenericCAO::updateTexturePos()
        }
 }
 
-void GenericCAO::updateTextures(const std::string &mod)
+void GenericCAO::updateTextures(std::string mod)
 {
        ITextureSource *tsrc = m_client->tsrc();
 

diff --git a/src/content_cao.h b/src/content_cao.h
index a0601d692be8f0631ccf23eaf94975ed65684637..3be75352992eb8754a00770cb21ff912423f2882 100644 (file)
--- a/src/content_cao.h
+++ b/src/content_cao.h
@@ -200,7 +200,9 @@ public:
 
        void updateTexturePos();
 
-       void updateTextures(const std::string &mod);
+       // std::string copy is mandatory as mod can be a class member and there is a swap
+       // on those class members
+       void updateTextures(std::string mod);
 
        void updateAnimation();