Guard last few debugging printfs in libssl
authorRichard Levitte <levitte@openssl.org>
Thu, 23 Mar 2017 13:26:43 +0000 (14:26 +0100)
committerRichard Levitte <levitte@openssl.org>
Thu, 23 Mar 2017 13:47:41 +0000 (14:47 +0100)
Fixes #2542

Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/3018)

ssl/d1_both.c
ssl/s3_srvr.c

index 232a6d4bf4ff7637f4ed92c2a2d13eda9f76289f..e6bc761e8bf236568c35da7f949c3dd9d77b4ccc 100644 (file)
@@ -1075,7 +1075,9 @@ int dtls1_send_change_cipher_spec(SSL *s, int a, int b)
 int dtls1_read_failed(SSL *s, int code)
 {
     if (code > 0) {
+#ifdef TLS_DEBUG
         fprintf(stderr, "invalid state reached %s:%d", __FILE__, __LINE__);
+#endif
         return 1;
     }
 
@@ -1147,7 +1149,9 @@ int dtls1_retransmit_buffered_messages(SSL *s)
                                      (frag->msg_header.seq,
                                       frag->msg_header.is_ccs), 0,
                                      &found) <= 0 && found) {
+#ifdef TLS_DEBUG
             fprintf(stderr, "dtls1_retransmit_message() failed\n");
+#endif
             return -1;
         }
     }
@@ -1247,7 +1251,9 @@ dtls1_retransmit_message(SSL *s, unsigned short seq, unsigned long frag_off,
 
     item = pqueue_find(s->d1->sent_messages, seq64be);
     if (item == NULL) {
+#ifdef TLS_DEBUG
         fprintf(stderr, "retransmit:  message %d non-existant\n", seq);
+#endif
         *found = 0;
         return 0;
     }
index 773358e4ce5d8fdbd26b70dbc9141887dbb5fbbb..ba17f1b562812c2fc2ce6719bdf7782e5c667393 100644 (file)
@@ -3164,7 +3164,9 @@ int ssl3_get_cert_verify(SSL *s)
             goto f_err;
         }
         if (i != 64) {
+#ifdef SSL_DEBUG
             fprintf(stderr, "GOST signature length is %d", i);
+#endif
         }
         for (idx = 0; idx < 64; idx++) {
             signature[63 - idx] = p[idx];