tegra: lcd: Merge tegra124-lcd.c into display.c
authorSimon Glass <sjg@chromium.org>
Sat, 30 Jan 2016 23:37:47 +0000 (16:37 -0700)
committerTom Warren <twarren@nvidia.com>
Tue, 16 Feb 2016 16:17:51 +0000 (09:17 -0700)
There isn't a lot of benefit of have two separate files. With driver model
the code needs to be in the same driver, so it's better to have it in the
same file.

Signed-off-by: Simon Glass <sjg@chromium.org>
Acked-by: Anatolij Gustschin <agust@denx.de>
Signed-off-by: Tom Warren <twarren@nvidia.com>
arch/arm/include/asm/arch-tegra/dc.h
drivers/video/tegra124/Makefile
drivers/video/tegra124/display.c
drivers/video/tegra124/tegra124-lcd.c [deleted file]

index 3a87f0b9566a227a0e0da920aa2e77f55b13d5e6..3a7ee5e77baf8b690818989aee390095831104b7 100644 (file)
@@ -566,9 +566,4 @@ enum {
 #define DC_N_WINDOWS                   5
 #define DC_REG_SAVE_SPACE              (DC_N_WINDOWS + 5)
 
-struct display_timing;
-
-int display_init(void *lcdbase, int fb_bits_per_pixel,
-                struct display_timing *timing);
-
 #endif /* __ASM_ARCH_TEGRA_DC_H */
index 52eedb0f08ce0ae21f7e36abc8000c5ef3753f74..4287b9a25fd82f095b36ef69174c059f0aaa877e 100644 (file)
@@ -7,4 +7,3 @@
 obj-y += display.o
 obj-y += dp.o
 obj-y += sor.o
-obj-y += tegra124-lcd.o
index 610ffa9684ba749113547b18d84d6660cc3013de..b4c4093694a2d4c444cb38e9c7051854f451f2d9 100644 (file)
@@ -376,8 +376,8 @@ err:
        return ret;
 }
 
-int display_init(void *lcdbase, int fb_bits_per_pixel,
-                struct display_timing *timing)
+static int display_init(void *lcdbase, int fb_bits_per_pixel,
+                       struct display_timing *timing)
 {
        struct dc_ctlr *dc_ctlr;
        const void *blob = gd->fdt_blob;
@@ -462,3 +462,80 @@ int display_init(void *lcdbase, int fb_bits_per_pixel,
 
        return 0;
 }
+
+enum {
+       /* Maximum LCD size we support */
+       LCD_MAX_WIDTH           = 1920,
+       LCD_MAX_HEIGHT          = 1200,
+       LCD_MAX_LOG2_BPP        = 4,            /* 2^4 = 16 bpp */
+};
+
+vidinfo_t panel_info = {
+       /* Insert a value here so that we don't end up in the BSS */
+       .vl_col = -1,
+};
+
+int tegra_lcd_check_next_stage(const void *blob, int wait)
+{
+       return 0;
+}
+
+void tegra_lcd_early_init(const void *blob)
+{
+       /*
+        * Go with the maximum size for now. We will fix this up after
+        * relocation. These values are only used for memory alocation.
+        */
+       panel_info.vl_col = LCD_MAX_WIDTH;
+       panel_info.vl_row = LCD_MAX_HEIGHT;
+       panel_info.vl_bpix = LCD_MAX_LOG2_BPP;
+}
+
+static int tegra124_lcd_init(void *lcdbase)
+{
+       struct display_timing timing;
+       int ret;
+
+       clock_set_up_plldp();
+       clock_start_periph_pll(PERIPH_ID_HOST1X, CLOCK_ID_PERIPH, 408000000);
+
+       clock_enable(PERIPH_ID_HOST1X);
+       clock_enable(PERIPH_ID_DISP1);
+       clock_enable(PERIPH_ID_PWM);
+       clock_enable(PERIPH_ID_DPAUX);
+       clock_enable(PERIPH_ID_SOR0);
+       udelay(2);
+
+       reset_set_enable(PERIPH_ID_HOST1X, 0);
+       reset_set_enable(PERIPH_ID_DISP1, 0);
+       reset_set_enable(PERIPH_ID_PWM, 0);
+       reset_set_enable(PERIPH_ID_DPAUX, 0);
+       reset_set_enable(PERIPH_ID_SOR0, 0);
+
+       ret = display_init(lcdbase, 1 << LCD_BPP, &timing);
+       if (ret)
+               return ret;
+
+       panel_info.vl_col = roundup(timing.hactive.typ, 16);
+       panel_info.vl_row = timing.vactive.typ;
+
+       lcd_set_flush_dcache(1);
+
+       return 0;
+}
+
+void lcd_ctrl_init(void *lcdbase)
+{
+       ulong start;
+       int ret;
+
+       start = get_timer(0);
+       ret = tegra124_lcd_init(lcdbase);
+       debug("LCD init took %lu ms\n", get_timer(start));
+       if (ret)
+               printf("%s: Error %d\n", __func__, ret);
+}
+
+void lcd_enable(void)
+{
+}
diff --git a/drivers/video/tegra124/tegra124-lcd.c b/drivers/video/tegra124/tegra124-lcd.c
deleted file mode 100644 (file)
index cfdc77f..0000000
+++ /dev/null
@@ -1,95 +0,0 @@
-/*
- * Copyright 2014 Google Inc.
- *
- * SPDX-License-Identifier:     GPL-2.0+
- *
- */
-
-#include <common.h>
-#include <errno.h>
-#include <fdtdec.h>
-#include <lcd.h>
-#include <asm/gpio.h>
-#include <asm/arch-tegra/clk_rst.h>
-#include <asm/arch/clock.h>
-#include <asm/arch-tegra/dc.h>
-#include <asm/io.h>
-
-DECLARE_GLOBAL_DATA_PTR;
-
-enum {
-       /* Maximum LCD size we support */
-       LCD_MAX_WIDTH           = 1920,
-       LCD_MAX_HEIGHT          = 1200,
-       LCD_MAX_LOG2_BPP        = 4,            /* 2^4 = 16 bpp */
-};
-
-vidinfo_t panel_info = {
-       /* Insert a value here so that we don't end up in the BSS */
-       .vl_col = -1,
-};
-
-int tegra_lcd_check_next_stage(const void *blob, int wait)
-{
-       return 0;
-}
-
-void tegra_lcd_early_init(const void *blob)
-{
-       /*
-        * Go with the maximum size for now. We will fix this up after
-        * relocation. These values are only used for memory alocation.
-        */
-       panel_info.vl_col = LCD_MAX_WIDTH;
-       panel_info.vl_row = LCD_MAX_HEIGHT;
-       panel_info.vl_bpix = LCD_MAX_LOG2_BPP;
-}
-
-static int tegra124_lcd_init(void *lcdbase)
-{
-       struct display_timing timing;
-       int ret;
-
-       clock_set_up_plldp();
-       clock_start_periph_pll(PERIPH_ID_HOST1X, CLOCK_ID_PERIPH, 408000000);
-
-       clock_enable(PERIPH_ID_HOST1X);
-       clock_enable(PERIPH_ID_DISP1);
-       clock_enable(PERIPH_ID_PWM);
-       clock_enable(PERIPH_ID_DPAUX);
-       clock_enable(PERIPH_ID_SOR0);
-       udelay(2);
-
-       reset_set_enable(PERIPH_ID_HOST1X, 0);
-       reset_set_enable(PERIPH_ID_DISP1, 0);
-       reset_set_enable(PERIPH_ID_PWM, 0);
-       reset_set_enable(PERIPH_ID_DPAUX, 0);
-       reset_set_enable(PERIPH_ID_SOR0, 0);
-
-       ret = display_init(lcdbase, 1 << LCD_BPP, &timing);
-       if (ret)
-               return ret;
-
-       panel_info.vl_col = roundup(timing.hactive.typ, 16);
-       panel_info.vl_row = timing.vactive.typ;
-
-       lcd_set_flush_dcache(1);
-
-       return 0;
-}
-
-void lcd_ctrl_init(void *lcdbase)
-{
-       ulong start;
-       int ret;
-
-       start = get_timer(0);
-       ret = tegra124_lcd_init(lcdbase);
-       debug("LCD init took %lu ms\n", get_timer(start));
-       if (ret)
-               printf("%s: Error %d\n", __func__, ret);
-}
-
-void lcd_enable(void)
-{
-}