rockchip: rk3188: move usb uart init into arch_cpu_init()
authorKever Yang <kever.yang@rock-chips.com>
Mon, 22 Jul 2019 11:59:14 +0000 (19:59 +0800)
committerKever Yang <kever.yang@rock-chips.com>
Mon, 29 Jul 2019 02:25:27 +0000 (10:25 +0800)
The SoC feature init will be better to use arch_cpu_init() and
goes to soc file.

Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
arch/arm/mach-rockchip/rk3188-board-spl.c
arch/arm/mach-rockchip/rk3188/rk3188.c

index 017bc6e805ab0999ca1cd887a1e168913dea296b..05ae3eca98ebfa6ab027f5ff1283b07470a6b75e 100644 (file)
 #include <asm/io.h>
 #include <asm/arch-rockchip/bootrom.h>
 #include <asm/arch-rockchip/clock.h>
-#include <asm/arch-rockchip/grf_rk3188.h>
-#include <asm/arch-rockchip/hardware.h>
 #include <asm/arch-rockchip/periph.h>
-#include <asm/arch-rockchip/pmu_rk3188.h>
 #include <asm/arch-rockchip/sdram.h>
 #include <dm/root.h>
 #include <dm/test.h>
@@ -70,6 +67,11 @@ fallback:
        return BOOT_DEVICE_MMC1;
 }
 
+__weak int arch_cpu_init(void)
+{
+       return 0;
+}
+
 void board_init_f(ulong dummy)
 {
        struct udevice *dev;
@@ -88,24 +90,7 @@ void board_init_f(ulong dummy)
        printascii("U-Boot SPL board init");
 #endif
 
-#ifdef CONFIG_ROCKCHIP_USB_UART
-       rk_clrsetreg(&grf->uoc0_con[0],
-                    SIDDQ_MASK | UOC_DISABLE_MASK | COMMON_ON_N_MASK,
-                    1 << SIDDQ_SHIFT | 1 << UOC_DISABLE_SHIFT |
-                    1 << COMMON_ON_N_SHIFT);
-       rk_clrsetreg(&grf->uoc0_con[2],
-                    SOFT_CON_SEL_MASK, 1 << SOFT_CON_SEL_SHIFT);
-       rk_clrsetreg(&grf->uoc0_con[3],
-                    OPMODE_MASK | XCVRSELECT_MASK |
-                    TERMSEL_FULLSPEED_MASK | SUSPENDN_MASK,
-                    OPMODE_NODRIVING << OPMODE_SHIFT |
-                    XCVRSELECT_FSTRANSC << XCVRSELECT_SHIFT |
-                    1 << TERMSEL_FULLSPEED_SHIFT |
-                    1 << SUSPENDN_SHIFT);
-       rk_clrsetreg(&grf->uoc0_con[0],
-                    BYPASSSEL_MASK | BYPASSDMEN_MASK,
-                    1 << BYPASSSEL_SHIFT | 1 << BYPASSDMEN_SHIFT);
-#endif
+       arch_cpu_init();
 
        ret = spl_early_init();
        if (ret) {
index 933484e0df91fa1eac27572ca4fa772305562548..f7e12a95b2dace64ce84f14d94c540d54d1b8386 100644 (file)
@@ -7,11 +7,12 @@
 #include <asm/arch-rockchip/grf_rk3188.h>
 #include <asm/arch-rockchip/hardware.h>
 
+#define GRF_BASE       0x20008000
+
 #ifdef CONFIG_DEBUG_UART_BOARD_INIT
 void board_debug_uart_init(void)
 {
        /* Enable early UART on the RK3188 */
-#define GRF_BASE       0x20008000
        struct rk3188_grf * const grf = (void *)GRF_BASE;
        enum {
                GPIO1B1_SHIFT           = 2,
@@ -34,3 +35,28 @@ void board_debug_uart_init(void)
                     GPIO1B0_UART2_SIN << GPIO1B0_SHIFT);
 }
 #endif
+
+int arch_cpu_init(void)
+{
+#ifdef CONFIG_ROCKCHIP_USB_UART
+       struct rk3188_grf * const grf = (void *)GRF_BASE;
+
+       rk_clrsetreg(&grf->uoc0_con[0],
+                    SIDDQ_MASK | UOC_DISABLE_MASK | COMMON_ON_N_MASK,
+                    1 << SIDDQ_SHIFT | 1 << UOC_DISABLE_SHIFT |
+                    1 << COMMON_ON_N_SHIFT);
+       rk_clrsetreg(&grf->uoc0_con[2],
+                    SOFT_CON_SEL_MASK, 1 << SOFT_CON_SEL_SHIFT);
+       rk_clrsetreg(&grf->uoc0_con[3],
+                    OPMODE_MASK | XCVRSELECT_MASK |
+                    TERMSEL_FULLSPEED_MASK | SUSPENDN_MASK,
+                    OPMODE_NODRIVING << OPMODE_SHIFT |
+                    XCVRSELECT_FSTRANSC << XCVRSELECT_SHIFT |
+                    1 << TERMSEL_FULLSPEED_SHIFT |
+                    1 << SUSPENDN_SHIFT);
+       rk_clrsetreg(&grf->uoc0_con[0],
+                    BYPASSSEL_MASK | BYPASSDMEN_MASK,
+                    1 << BYPASSSEL_SHIFT | 1 << BYPASSDMEN_SHIFT);
+#endif
+       return 0;
+}