Noise: Prevent unittest crash caused by division by zero

diff --git a/src/noise.cpp b/src/noise.cpp
index b918c9936851ccb638dcf617f1cc6c8ef9dc34fd..abd29f3ecdba2d151d334186f1aee45693e5aa4e 100644 (file)
--- a/src/noise.cpp
+++ b/src/noise.cpp
@@ -130,7 +130,9 @@ s32 PcgRandom::range(s32 min, s32 max)
        if (max < min)
                throw PrngException("Invalid range (max < min)");
 
-       u32 bound = max - min + 1;
+       // We have to cast to s64 because otherwise this could overflow,
+       // and signed overflow is undefined behavior.
+       u32 bound = (s64)max - (s64)min + 1;
        return range(bound) + min;
 }