bdinfo: net: Drop legacy ethernet bdinfo
authorSimon Glass <sjg@chromium.org>
Sun, 10 May 2020 20:16:53 +0000 (14:16 -0600)
committerTom Rini <trini@konsulko.com>
Thu, 25 Jun 2020 17:24:12 +0000 (13:24 -0400)
This code pre-dates driver model and the migration date is nearly upon us.
Pare the print_eths() function down and enable it for driver model, since
it works correctly.

The IP address is already printed in print_eth_ip_addr() so we can remove
that.

Since this results in a one-line print_eths() function, inline it.

Signed-off-by: Simon Glass <sjg@chromium.org>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
cmd/bdinfo.c

index 1a08e14d0819a48813e974fea517e00ebd84461c..f1d6a013f5213a17031ca16748401b15b254b3fe 100644 (file)
@@ -36,27 +36,6 @@ static void print_eth(int idx)
        printf("%-12s= %s\n", name, val);
 }
 
-#ifndef CONFIG_DM_ETH
-__maybe_unused
-static void print_eths(void)
-{
-       struct eth_device *dev;
-       int i = 0;
-
-       do {
-               dev = eth_get_dev_by_index(i);
-               if (dev) {
-                       printf("eth%dname    = %s\n", i, dev->name);
-                       print_eth(i);
-                       i++;
-               }
-       } while (dev);
-
-       printf("current eth = %s\n", eth_get_name());
-       printf("ip_addr     = %s\n", env_get("ipaddr"));
-}
-#endif
-
 static void print_lnum(const char *name, unsigned long long value)
 {
        printf("%-12s= 0x%.8llX\n", name, value);
@@ -118,9 +97,8 @@ int do_bdinfo(struct cmd_tbl *cmdtp, int flag, int argc, char *const argv[])
        print_num("relocaddr", gd->relocaddr);
        print_num("reloc off", gd->reloc_off);
        printf("%-12s= %u-bit\n", "Build", (uint)sizeof(void *) * 8);
-#if defined(CONFIG_CMD_NET) && !defined(CONFIG_DM_ETH)
-       print_eths();
-#endif
+       if (IS_ENABLED(CONFIG_CMD_NET))
+               printf("current eth = %s\n", eth_get_name());
        print_num("fdt_blob", (ulong)gd->fdt_blob);
        print_num("new_fdt", (ulong)gd->new_fdt);
        print_num("fdt_size", (ulong)gd->fdt_size);