Remove some deprecated curve 448 code and remove some unneeded defines
authorMatt Caswell <matt@openssl.org>
Wed, 15 Nov 2017 16:19:15 +0000 (16:19 +0000)
committerMatt Caswell <matt@openssl.org>
Tue, 20 Feb 2018 12:59:29 +0000 (12:59 +0000)
Reviewed-by: Bernd Edlinger <bernd.edlinger@hotmail.de>
(Merged from https://github.com/openssl/openssl/pull/5105)

crypto/ec/curve448/decaf.c
crypto/ec/curve448/decaf/common.h
crypto/ec/curve448/point_448.h

index 9f01454b40f8bada4bb8d067f125d5d43ac3627a..bbee4b022ef09f25f13138dbce8e04e96b869352 100644 (file)
@@ -1345,13 +1345,6 @@ void decaf_ed448_convert_public_key_to_x448 (
     }
 }
 
-void decaf_x448_generate_key (
-    uint8_t out[X_PUBLIC_BYTES],
-    const uint8_t scalar[X_PRIVATE_BYTES]
-) {
-    decaf_x448_derive_public_key(out,scalar);
-}
-
 void API_NS(point_mul_by_ratio_and_encode_like_x448) (
     uint8_t out[X_PUBLIC_BYTES],
     const point_t p
index 64719ad9715b79a4a20a61780e90111c7a3eff67..a9d10cffa84379a3ad899aed1aa0b115228e10d7 100644 (file)
@@ -29,14 +29,6 @@ extern "C" {
 #define DECAF_WARN_UNUSED __attribute__((warn_unused_result))
 #define DECAF_NONNULL __attribute__((nonnull))
 #define DECAF_INLINE inline __attribute__((always_inline,unused))
-// Cribbed from libnotmuch
-#if defined (__clang_major__) && __clang_major__ >= 3 \
-    || defined (__GNUC__) && __GNUC__ >= 5 \
-    || defined (__GNUC__) && __GNUC__ == 4 && __GNUC_MINOR__ >= 5
-#define DECAF_DEPRECATED(msg) __attribute__ ((deprecated(msg)))
-#else
-#define DECAF_DEPRECATED(msg) __attribute__ ((deprecated))
-#endif
 /** @endcond */
 
 /* Internal word types.
index bc1cb43a00a71493d1e4dbb45dabfc7f9c3c7aee..1757129e84c48e4f9a0595d313822036710cda59 100644 (file)
@@ -430,21 +430,6 @@ void decaf_448_point_mul_by_ratio_and_encode_like_x448 (
 
 /** The base point for X448 Diffie-Hellman */
 extern const uint8_t decaf_x448_base_point[DECAF_X448_PUBLIC_BYTES] DECAF_API_VIS;
-
-/**
- * @brief RFC 7748 Diffie-Hellman base point scalarmul.  This function uses
- * a different (non-Decaf) encoding.
- *
- * @deprecated Renamed to decaf_x448_derive_public_key.
- * I have no particular timeline for removing this name.
- *
- * @param [out] scaled The scaled point base*scalar
- * @param [in] scalar The scalar to multiply by.
- */
-void decaf_x448_generate_key (
-    uint8_t out[DECAF_X448_PUBLIC_BYTES],
-    const uint8_t scalar[DECAF_X448_PRIVATE_BYTES]
-) DECAF_API_VIS DECAF_NONNULL DECAF_NOINLINE DECAF_DEPRECATED("Renamed to decaf_x448_derive_public_key");
     
 /**
  * @brief RFC 7748 Diffie-Hellman base point scalarmul.  This function uses