fix

diff --git a/TODO b/TODO
index bf2c137114f9a8d5339fca5c2a1296f1d413c3f1..a51ebb40bc2f181b55f2446e8ac5d0551e90a25d 100644 (file)
--- a/TODO
+++ b/TODO
@@ -4,6 +4,15 @@
   so that some of the 'local' IPs do not work due to the bindto);  the result
   seems to be that the plugin tries some of the broken addresses, fails and the
   transport-level connection never comes up.
+* Mantis:
+  - 1727 --- investigate (NEW)
+  - 1694 --- try to reproduce (non-deterministic, w. testcase, need core/valgrind)
+  - 1725 --- try to reproduce (non-deterministic, w. testcase, need core)
+  - 1724 --- try to reproduce
+  - 1709 --- need more data (Nate)
+  - 1717 --- need more data (Nate)
+  - 1701 --- try to reproduce (Nate)
+  - 1705 --- try to reproduce (Nate)
 * clean buildbots
 
 0.9.0pre4:

diff --git a/src/transport/gnunet-service-transport.c b/src/transport/gnunet-service-transport.c
index ee18c9ba097a09245ee87594d74c7e898d3d76b4..1dace5022878c6a938c06a746e257a89d4596e17 100644 (file)
--- a/src/transport/gnunet-service-transport.c
+++ b/src/transport/gnunet-service-transport.c
@@ -6278,8 +6278,7 @@ shutdown_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
               "Transport service is unloading plugins...\n");
 #endif
-  plug = plugins;
-  while (plug != NULL)
+  while (NULL != (plug = plugins))
     {
       if (plug->address_update_task != GNUNET_SCHEDULER_NO_TASK)
        {
@@ -6294,9 +6293,8 @@ shutdown_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
           plug->addresses = al->next;
           GNUNET_free (al);
         }
-      tmp = plug->next;
+      plugins = plug->next;
       GNUNET_free (plug);
-      plug = tmp;
     }
   if (my_private_key != NULL)
     GNUNET_CRYPTO_rsa_key_free (my_private_key);