Fix double frees.
authorBen Laurie <ben@links.org>
Tue, 22 Apr 2014 11:38:26 +0000 (12:38 +0100)
committerBen Laurie <ben@links.org>
Tue, 22 Apr 2014 16:00:52 +0000 (17:00 +0100)
Conflicts:
CHANGES

CHANGES
crypto/pkcs7/pk7_doit.c
crypto/ts/ts_rsp_verify.c

diff --git a/CHANGES b/CHANGES
index c63fa17b9daa0b3b5fef2edc723b51ad7c40ad4a..d9205e53b27104e2fdc1f59b92d83d7572626287 100644 (file)
--- a/CHANGES
+++ b/CHANGES
@@ -4,6 +4,9 @@
 
  Changes between 1.0.1g and 1.0.2 [xx XXX xxxx]
 
+  *) Fix some double frees. These are not thought to be exploitable.
+     [mancha <mancha1@zoho.com>]
+
   *) Use algorithm specific chains in SSL_CTX_use_certificate_chain_file():
      this fixes a limiation in previous versions of OpenSSL.
      [Steve Henson]
index 77fda3b82a07692ee85158d4f7cfc88b44bd5d10..4c12a9dcc9dfb467b037f5baddd4667732ee7d7c 100644 (file)
@@ -928,6 +928,7 @@ int PKCS7_SIGNER_INFO_sign(PKCS7_SIGNER_INFO *si)
        if (EVP_DigestSignUpdate(&mctx,abuf,alen) <= 0)
                goto err;
        OPENSSL_free(abuf);
+       abuf = NULL;
        if (EVP_DigestSignFinal(&mctx, NULL, &siglen) <= 0)
                goto err;
        abuf = OPENSSL_malloc(siglen);
index afe16afbe454f7d1e38c7c651b81a30b60649479..3c7f816d12b1d06137f9ed4485d141c4e2a9bb58 100644 (file)
@@ -629,6 +629,7 @@ static int TS_compute_imprint(BIO *data, TS_TST_INFO *tst_info,
        X509_ALGOR_free(*md_alg);
        OPENSSL_free(*imprint);
        *imprint_len = 0;
+       *imprint = 0;
        return 0;
        }