Fix a possible crash in dsa_builtin_paramgen2.
authorBernd Edlinger <bernd.edlinger@hotmail.de>
Tue, 13 Jun 2017 19:22:45 +0000 (21:22 +0200)
committerRich Salz <rsalz@openssl.org>
Wed, 14 Jun 2017 13:50:59 +0000 (09:50 -0400)
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/3675)
(cherry picked from commit fb0a64126b8c11a6961dfa1323c3602b591af7df)

crypto/dsa/dsa_gen.c

index 3efeab84fa4245732378c2597e41aa8199cc145f..e58ad8d70d315eb771b1940514b8073887cf554b 100644 (file)
@@ -376,6 +376,8 @@ int dsa_builtin_paramgen2(DSA *ret, size_t L, size_t N,
     } else {
         p = BN_CTX_get(ctx);
         q = BN_CTX_get(ctx);
+        if (q == NULL)
+            goto err;
     }
 
     if (!BN_lshift(test, BN_value_one(), L - 1))