Skipping all tests just because one algorithm is disabled seems a bit harsch.
authorRichard Levitte <levitte@openssl.org>
Mon, 6 Jun 2005 08:38:05 +0000 (08:38 +0000)
committerRichard Levitte <levitte@openssl.org>
Mon, 6 Jun 2005 08:38:05 +0000 (08:38 +0000)
PR: 1089

util/selftest.pl

index e9d5aa8938ec3d1f2d3f9fa82d49b68ef0ff86a7..736eacb11ec972a900cfa85707baa0161a965b0e 100644 (file)
@@ -130,15 +130,21 @@ if (system("make 2>&1 | tee make.log") > 255) {
     goto err;
 }
 
-$_=$options;
-s/no-asm//;
-s/no-shared//;
-s/no-krb5//;
-if (/no-/)
-{
-    print OUT "Test skipped.\n";
-    goto err;
-}
+# Not sure why this is here.  The tests themselves can detect if their
+# particular feature isn't included, and should therefore skip themselves.
+# To skip *all* tests just because one algorithm isn't included is like
+# shooting mosquito with an elephant gun...
+#                   -- Richard Levitte, inspired by problem report 1089
+#
+#$_=$options;
+#s/no-asm//;
+#s/no-shared//;
+#s/no-krb5//;
+#if (/no-/)
+#{
+#    print OUT "Test skipped.\n";
+#    goto err;
+#}
 
 print "Running make test...\n";
 if (system("make test 2>&1 | tee maketest.log") > 255)