better diagnostics

diff --git a/src/include/gnunet_connection_lib.h b/src/include/gnunet_connection_lib.h
index 1a3ef4b54ab257aa4bba3432357e0e1d56a306ef..d83da71ce9d5fd09c47b714fe8a1b479327df167 100644 (file)
--- a/src/include/gnunet_connection_lib.h
+++ b/src/include/gnunet_connection_lib.h
@@ -40,7 +40,9 @@ extern "C"
 \r
 /**\r
  * Timeout we use on TCP connect before trying another\r
- * result from the DNS resolver. 5s.\r
+ * result from the DNS resolver.  Actual value used\r
+ * is this value divided by the number of address families.\r
+ * Default is 5s.\r
  */\r
 #define GNUNET_CONNECTION_CONNECT_RETRY_TIMEOUT GNUNET_TIME_relative_multiply (GNUNET_TIME_UNIT_SECONDS, 5)\r
 \r

diff --git a/src/transport/test_transport_api.c b/src/transport/test_transport_api.c
index f98bce57375637cec420437902071d65e936b178..2aa12bcbd3502890601e4c5540749b554be0d9f7 100644 (file)
--- a/src/transport/test_transport_api.c
+++ b/src/transport/test_transport_api.c
@@ -31,7 +31,7 @@
 #include "gnunet_transport_service.h"
 #include "transport.h"
 
-#define VERBOSE GNUNET_NO
+#define VERBOSE GNUNET_YES
 
 #define START_ARM GNUNET_YES
 

diff --git a/src/util/client.c b/src/util/client.c
index 9a2f4767887c99d7f2e7e8e251c0b1ecd26af7df..2da392fb4b2a325e6f92bcc43b81237653ea018b 100644 (file)
--- a/src/util/client.c
+++ b/src/util/client.c
@@ -143,14 +143,22 @@ GNUNET_CLIENT_connect (struct GNUNET_SCHEDULER_Handle *sched,
                                               "HOSTNAME", &hostname)))
     {
       GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
-                  "Could not determine valid hostname and port for service `%s' from configuration.\n",
+                  _("Could not determine valid hostname and port for service `%s' from configuration.\n"),
                   service_name);
       return NULL;
     }
+  if (0 == strlen (hostname))
+    {
+      GNUNET_free (hostname);
+      GNUNET_log (GNUNET_ERROR_TYPE_WARNING,
+                  _("Need a non-empty hostname for service `%s'.\n"),
+                 service_name);
+      return NULL;
+    }
   sock = GNUNET_CONNECTION_create_from_connect (sched,
-                                                    hostname,
-                                                    port,
-                                                    GNUNET_SERVER_MAX_MESSAGE_SIZE);
+                                               hostname,
+                                               port,
+                                               GNUNET_SERVER_MAX_MESSAGE_SIZE);
   GNUNET_free (hostname);
   if (sock == NULL)
     return NULL;

diff --git a/src/util/connection.c b/src/util/connection.c
index 193621b65f1e1c25f4577b841377acc0c088d427..fa6542325db3fcafb78fcdee08ea54b1b5d29d3d 100644 (file)
--- a/src/util/connection.c
+++ b/src/util/connection.c
@@ -349,10 +349,13 @@ GNUNET_CONNECTION_get_address (struct GNUNET_CONNECTION_Handle *sock,
   return GNUNET_OK;
 }
 
+
 /**
  * Perform a DNS lookup for the hostname associated
  * with the current socket, iterating over the address
  * families as specified in the "address_families" array.
+ *
+ * @param sock the socket for which to do the lookup
  */
 static void
 try_lookup (struct GNUNET_CONNECTION_Handle *sock)
@@ -360,6 +363,7 @@ try_lookup (struct GNUNET_CONNECTION_Handle *sock)
   struct addrinfo hints;
   int ec;
 
+  GNUNET_assert (0 < strlen (sock->hostname)); /* sanity check */
   while ( (sock->ai_pos == NULL) &&
          (sock->af_fam_offset > 0) )
     {
@@ -368,11 +372,32 @@ try_lookup (struct GNUNET_CONNECTION_Handle *sock)
       memset (&hints, 0, sizeof (hints));
       hints.ai_family = address_families[--sock->af_fam_offset];
       hints.ai_socktype = SOCK_STREAM;
-      if (0 != (ec = getaddrinfo (sock->hostname, NULL, &hints, &sock->ai)))
+#if 0
+      GNUNET_log (GNUNET_ERROR_TYPE_INFO,
+                 _("`%s' tries to resolve address family %d and hostname `%s:%u'\n"),
+                 "getaddrinfo", 
+                 address_families[sock->af_fam_offset],
+                 sock->hostname,
+                 sock->port);
+#endif
+      ec = getaddrinfo (sock->hostname, NULL, &hints, &sock->ai);
+#if 0
+      GNUNET_log (GNUNET_ERROR_TYPE_INFO,
+                 _("`%s' returned from resolving address family %d and hostname `%s:%u'\n"),
+                 "getaddrinfo", 
+                 address_families[sock->af_fam_offset],
+                 sock->hostname,
+                 sock->port);
+#endif
+      if (0 != ec)
        {
          GNUNET_log (GNUNET_ERROR_TYPE_INFO | GNUNET_ERROR_TYPE_BULK,
-                     "`%s' failed for hostname `%s': %s\n",
-                     "getaddrinfo", sock->hostname, gai_strerror (ec));
+                     _("`%s' failed for address family %d and hostname `%s:%u': %s\n"),
+                     "getaddrinfo", 
+                     address_families[sock->af_fam_offset],
+                     sock->hostname,
+                     sock->port,
+                     gai_strerror (ec));
          sock->ai = NULL;
        }
       sock->ai_pos = sock->ai;
@@ -477,10 +502,12 @@ connect_continuation (void *cls,
                       const struct GNUNET_SCHEDULER_TaskContext *tc)
 {
   struct GNUNET_CONNECTION_Handle *sock = cls;
+  struct GNUNET_TIME_Relative delay;
   unsigned int len;
   int error;
 
-  /* nobody needs to wait for us anymore... */
+  GNUNET_assert (0 < strlen (sock->hostname)); /* sanity check */
+   /* nobody needs to wait for us anymore... */
   sock->connect_task = GNUNET_SCHEDULER_NO_TASK;
   /* Note: write-ready does NOT mean connect succeeded,
      we need to use getsockopt to be sure */
@@ -493,8 +520,9 @@ connect_continuation (void *cls,
     {
 #if DEBUG_CONNECTION
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                 "Failed to establish TCP connection to `%s'\n",
-                 GNUNET_a2s(sock->addr, sock->addrlen));
+                 "Failed to establish TCP connection to `%s:%u': %s\n",
+                 GNUNET_a2s(sock->addr, sock->addrlen),
+                 STRERROR (GNUNET_MAX (error, errno)));
 #endif
       /* connect failed / timed out */
       GNUNET_break (GNUNET_OK == GNUNET_NETWORK_socket_close (sock->sock));
@@ -504,7 +532,9 @@ connect_continuation (void *cls,
           /* failed for good */
 #if DEBUG_CONNECTION
          GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                     "Failed to establish TCP connection, no further addresses to try.\n");
+                     "Failed to establish TCP connection to `%s:%u', no further addresses to try.\n",
+                     sock->hostname,
+                     sock->port);
 #endif
          /* connect failed / timed out */
           GNUNET_break (sock->ai_pos == NULL);
@@ -512,13 +542,28 @@ connect_continuation (void *cls,
           sock->ai = NULL;
           return;
         }
+      delay = GNUNET_CONNECTION_CONNECT_RETRY_TIMEOUT;
+      if (sock->nth.notify_ready != NULL)
+       delay = GNUNET_TIME_relative_min (delay,
+                                         GNUNET_TIME_absolute_get_remaining (sock->nth.transmit_timeout));
+      if (sock->receiver != NULL)
+       delay = GNUNET_TIME_relative_min (delay,
+                                         GNUNET_TIME_absolute_get_remaining (sock->receive_timeout));
+      delay.value /= (1 + sock->af_fam_offset);
+#if DEBUG_CONNECTION
+      GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
+                 "Will try to connect to `%s' for %llu ms\n",
+                 GNUNET_a2s (sock->addr,
+                             sock->addrlen),
+                 delay.value);
+#endif
       sock->connect_task = GNUNET_SCHEDULER_add_write_net (tc->sched, GNUNET_NO,    /* abort on shutdown */
-                                                       GNUNET_SCHEDULER_PRIORITY_KEEP,
-                                                       GNUNET_SCHEDULER_NO_TASK,
-                                                       GNUNET_CONNECTION_CONNECT_RETRY_TIMEOUT,
-                                                       sock->sock,
-                                                       &connect_continuation,
-                                                       sock);
+                                                          GNUNET_SCHEDULER_PRIORITY_KEEP,
+                                                          GNUNET_SCHEDULER_NO_TASK,
+                                                          delay,
+                                                          sock->sock,
+                                                          &connect_continuation,
+                                                          sock);
       return;
     }
   /* connect succeeded! clean up "ai" */
@@ -552,6 +597,7 @@ GNUNET_CONNECTION_create_from_connect (struct GNUNET_SCHEDULER_Handle
 {
   struct GNUNET_CONNECTION_Handle *ret;
 
+  GNUNET_assert (0 < strlen (hostname)); /* sanity check */
   ret = GNUNET_malloc (sizeof (struct GNUNET_CONNECTION_Handle) + maxbuf);
   ret->sock = NULL;
   ret->sched = sched;
@@ -788,7 +834,9 @@ receive_ready (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
     {
 #if DEBUG_CONNECTION
       GNUNET_log (GNUNET_ERROR_TYPE_DEBUG,
-                  "Receive encounters error: time out...\n");
+                  "Receive from %s encounters error: time out by %llums...\n",
+                 GNUNET_a2s (sh->addr, sh->addrlen),
+                 now.value - sh->receive_timeout.value);
 #endif
       signal_timeout (sh);
       return;
@@ -1014,7 +1062,9 @@ transmit_timeout (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
   GNUNET_CONNECTION_TransmitReadyNotify notify;
 
 #if DEBUG_CONNECTION
-  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, "Transmit fails, time out reached.\n");
+  GNUNET_log (GNUNET_ERROR_TYPE_DEBUG, 
+             "Transmit to `%s' fails, time out reached.\n",
+             GNUNET_a2s (sock->addr, sock->addrlen));
 #endif
   notify = sock->nth.notify_ready;
   sock->nth.notify_ready = NULL;

diff --git a/src/util/service.c b/src/util/service.c
index 4786e678c641f4c21d974a61c018e70fedddbc0f..11fbcd5c25d36512f29cf1568bc7b21ff3fe8bb6 100644 (file)
--- a/src/util/service.c
+++ b/src/util/service.c
@@ -1104,7 +1104,11 @@ service_task (void *cls, const struct GNUNET_SCHEDULER_TaskContext *tc)
       sctx->ready_confirm_fd = -1;
       write_pid_file (sctx, getpid ());
     }
-
+  GNUNET_log (GNUNET_ERROR_TYPE_INFO,
+             _("Service `%s' runs at %s\n"),
+             sctx->serviceName,
+             GNUNET_a2s (sctx->addr,
+                         sctx->addrlen));
   sctx->task (sctx->task_cls, tc->sched, sctx->server, sctx->cfg);
 }