powerpc mpc85xx: Only clear TSR:WIS in watchdog_reset.
authorMark Marshall <mark.marshall@omicron.at>
Sun, 9 Sep 2012 23:06:03 +0000 (23:06 +0000)
committerAndy Fleming <afleming@freescale.com>
Mon, 22 Oct 2012 08:04:27 +0000 (03:04 -0500)
We should only write TSR_WIS to the SPRN_TSR register in
reset_85xx_watchdog.

The old code would cause the timer interrupt to be acknowledged when the
watchdog was reset, and we would then get no more timer interrupts.
This bug would affect all mpc85xx boards that have the watchdog enabled.

Signed-off-by: Mark Marshall <Mark.Marshall@omicron.at>
Signed-off-by: Andy Fleming <afleming@freescale.com>
arch/powerpc/cpu/mpc85xx/cpu.c

index 5ddb29435c139a7f0541a59e4a859b83919408df..a5048a130647383cb7925f8128cbed2800ed1281 100644 (file)
@@ -270,10 +270,7 @@ reset_85xx_watchdog(void)
        /*
         * Clear TSR(WIS) bit by writing 1
         */
-       unsigned long val;
-       val = mfspr(SPRN_TSR);
-       val |= TSR_WIS;
-       mtspr(SPRN_TSR, val);
+       mtspr(SPRN_TSR, TSR_WIS);
 }
 #endif /* CONFIG_WATCHDOG */