Revert "Network: fix a concurrency problem, by re-adding a copy in ConnectionCommand"

This reverts commit 5b04f5e7d231437b534f4cad39da78624d97c584.

diff --git a/src/network/connection.h b/src/network/connection.h
index 94d5aa1e9ffa181d2ae9a3db7d1779c7c3ceb7f5..e1bb613f084d4c5c07cca5546f1fcc9911830db8 100644 (file)
--- a/src/network/connection.h
+++ b/src/network/connection.h
@@ -330,18 +330,6 @@ struct ConnectionCommand
        bool raw = false;
 
        ConnectionCommand() = default;
-       ConnectionCommand &operator=(const ConnectionCommand &other)
-       {
-               type = other.type;
-               address = other.address;
-               peer_id = other.peer_id;
-               channelnum = other.channelnum;
-               // We must copy the buffer here to prevent race condition
-               data = SharedBuffer<u8>(*other.data, other.data.getSize());
-               reliable = other.reliable;
-               raw = other.reliable;
-               return *this;
-       }
 
        void serve(Address address_)
        {