luci-mod-admin-full: dnsmasq clarify non-wildcard mode
authorKevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
Wed, 17 May 2017 13:29:43 +0000 (14:29 +0100)
committerKevin Darbyshire-Bryant <6500011+ldir-EDB0@users.noreply.github.com>
Mon, 12 Nov 2018 15:38:36 +0000 (15:38 +0000)
'non-wildcard' interfaces enables dnsmasq's '--bind-dynamic' mode.
This binds dynamically to interfaces rather than wildcard addresses
*and* keeps track of interface comings/goings via a unique Linux api.

Quoting dnsmasq's author "bind-dynamic (bind individual addresses,
keep up with changes in interface config) ... On linux, there's actually
no sane reason not to use --bind-dynamic, and it's only not the default
for historical reasons."

listen/exclude interfaces may be used independently of bind dynamic mode
so removed the bogus dependency of 'nonwildcard' enabling access to
'listen/exclude' interfaces - they may be used in any mode..  In fact
the dnsmasq init script takes notice of include/exclude interfaces
irrespective of the 'nonwildcard' parameter.

Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
modules/luci-mod-network/luasrc/model/cbi/admin_network/dhcp.lua

index 3ac49d635d1b1a0c8050d2634a9afb8eea2c0e39..e886d84224080d93b3e06f2df01efcb6516eae27 100644 (file)
@@ -250,21 +250,19 @@ o.rmempty = false
 
 o = s:taboption("general", Flag, "nonwildcard",
        translate("Non-wildcard"),
-       translate("Bind only to specific interfaces rather than wildcard address."))
+       translate("Bind dynamically to interfaces rather than wildcard address (recommended as linux default)"))
 o.optional = false
-o.rmempty = false
+o.rmempty = true
 
 o = s:taboption("general", DynamicList, "interface",
        translate("Listen Interfaces"),
        translate("Limit listening to these interfaces, and loopback."))
 o.optional = true
-o:depends("nonwildcard", true)
 
 o = s:taboption("general", DynamicList, "notinterface",
        translate("Exclude interfaces"),
        translate("Prevent listening on these interfaces."))
 o.optional = true
-o:depends("nonwildcard", true)
 
 m:section(SimpleSection).template = "lease_status"