Server: do not enable images tests by default because it needs a special

ffmpeg version

diff --git a/.gitignore b/.gitignore
index a79cc6a976c82fc2553d5c9312f7e14304604749..debe118e10d453a9174a90687e93273d8ae39bae 100644 (file)
--- a/.gitignore
+++ b/.gitignore
@@ -13,3 +13,4 @@ public/stylesheets/vendor
 uploads
 thumbnails
 config/production.yaml
+ffmpeg

diff --git a/.travis.yml b/.travis.yml
index cb351c6133ecfbfa74ca0fdb07c742741e6f38d4..e6a92d883134ef4b0d9d577c96a0464b982fbe45 100644 (file)
--- a/.travis.yml
+++ b/.travis.yml
@@ -27,6 +27,7 @@ before_script:
   - mkdir -p $HOME/bin
   - cp ffmpeg-*-64bit-static/{ffmpeg,ffprobe,ffserver} $HOME/bin
   - export PATH=$HOME/bin:$PATH
+  - export NODE_TEST_IMAGE=true
 
 after_failure:
   - cat test1/logs/all-logs.log

diff --git a/server/tests/api/utils.js b/server/tests/api/utils.js
index 7c8698a0a1d4dd2f317557e696285fb476f4e360..314269b5c7c5529e27c8c5de822666f9ee2cbefd 100644 (file)
--- a/server/tests/api/utils.js
+++ b/server/tests/api/utils.js
@@ -350,18 +350,25 @@ function searchVideoWithSort (url, search, sort, end) {
 }
 
 function testImage (url, videoName, imagePath, callback) {
-  request(url)
-    .get(imagePath)
-    .expect(200)
-    .end(function (err, res) {
-      if (err) return callback(err)
-
-      fs.readFile(pathUtils.join(__dirname, 'fixtures', videoName + '.jpg'), function (err, data) {
+  // Don't test images if the node env is not set
+  // Because we need a special ffmpeg version for this test
+  if (process.env.NODE_TEST_IMAGE) {
+    request(url)
+      .get(imagePath)
+      .expect(200)
+      .end(function (err, res) {
         if (err) return callback(err)
 
-        callback(null, data.equals(res.body))
+        fs.readFile(pathUtils.join(__dirname, 'fixtures', videoName + '.jpg'), function (err, data) {
+          if (err) return callback(err)
+
+          callback(null, data.equals(res.body))
+        })
       })
-    })
+  } else {
+    console.log('Do not test images. Enable it by setting NODE_TEST_IMAGE env variable.')
+    callback(null, true)
+  }
 }
 
 function uploadVideo (url, accessToken, name, description, tags, fixture, specialStatus, end) {