Remove format string abuse with sane code.

With the old code, parts of the config file were interpreted as format string,
always a bad idea ...

diff --git a/src/arm/gnunet-service-arm.c b/src/arm/gnunet-service-arm.c
index 28d448f756e79d6dba1eb04506902b88c3b2e76a..189e1872caa069df01890cd7de4b948b0ca12e3a 100644 (file)
--- a/src/arm/gnunet-service-arm.c
+++ b/src/arm/gnunet-service-arm.c
@@ -462,11 +462,12 @@ start_process (struct ServiceList *sl,
          /* replace '{}' with service name */
          while (NULL != (optpos = strstr (options, "{}")))
            {
-             optpos[0] = '%';
-             optpos[1] = 's';
-             GNUNET_asprintf (&optpos, options, sl->name);
-             GNUNET_free (options);
-             options = optpos;
+              char *new_options;
+              /* terminate string at opening parenthesis */
+              *optpos = 0;
+              GNUNET_asprintf (&new_options, "%s%s%s", options, sl->name, optpos + 2);
+              GNUNET_free (options);
+              options = new_options;
            }
          /* replace '$PATH' with value associated with "PATH" */
          while (NULL != (optpos = strstr (options, "$")))