Now that we have xopen3(), it's just plain unclean to have xopen() with

O_CREAT.  Two users are still doing it (and thus getting permissions 777),
I'm not sure what permissions they should be using but here they are
changed to xopen3().  This costs us a dozen or so bytes, but removing the
777 from xopen() should get some of that back.

diff --git a/archival/unzip.c b/archival/unzip.c
index 68083e98754e3e48ebe99b2e3cf6ae7e40774ae2..2585cbf3fb104a472777d1ef8dd689e58c2179f5 100644 (file)
--- a/archival/unzip.c
+++ b/archival/unzip.c
@@ -333,7 +333,7 @@ int unzip_main(int argc, char **argv)
                        overwrite = o_always;
                case 'y': /* Open file and fall into unzip */
                        unzip_create_leading_dirs(dst_fn);
-                       dst_fd = xopen(dst_fn, O_WRONLY | O_CREAT);
+                       dst_fd = xopen(dst_fn, O_WRONLY | O_CREAT, 777);
                case -1: /* Unzip */
                        if (verbosity == v_normal) {
                                printf("  inflating: %s\n", dst_fn);

diff --git a/networking/ftpgetput.c b/networking/ftpgetput.c
index 767ace9fb8a74ea5f655cdc02bbf6be61820cafc..978601d26d57f34cb9c4fb830b918a5b2edd8b5a 100644 (file)
--- a/networking/ftpgetput.c
+++ b/networking/ftpgetput.c
@@ -166,7 +166,7 @@ static int ftp_receive(ftp_host_info_t *server, FILE *control_stream,
                if (do_continue) {
                        fd_local = xopen(local_path, O_APPEND | O_WRONLY);
                } else {
-                       fd_local = xopen(local_path, O_CREAT | O_TRUNC | O_WRONLY);
+                       fd_local = xopen3(local_path, O_CREAT | O_TRUNC | O_WRONLY, 777);
                }
        }