+ littering my code w/ comments about what troubles me.

diff --git a/applets/busybox.c b/applets/busybox.c
index 78f07e338a4b758f664295cec63f67964c29ef23..5f1c56bc3b7ba94e87a785af4655ad9a0516950e 100644 (file)
--- a/applets/busybox.c
+++ b/applets/busybox.c
@@ -420,10 +420,15 @@ int main(int argc, char **argv)
        const struct BB_applet  *a              = applets;
 
 #ifdef BB_FEATURE_INSTALLER    
+       /* 
+        * This style of argument parsing doesn't scale well 
+        * in the event that busybox starts wanting more --options.
+        * If someone has a cleaner approach, by all means implement it.
+        */
        if (argc > 1 && (strcmp(argv[1], "--install") == 0)) {
                int use_symbolic_links = 0;
 
-               /* to use symlinks, or to not use symlinks... */
+               /* to use symlinks, or not to use symlinks... */
                if (argc > 2) {
                        if ((strcmp(argv[2], "-s") == 0)) { 
                                use_symbolic_links = 1; 

diff --git a/busybox.c b/busybox.c
index 78f07e338a4b758f664295cec63f67964c29ef23..5f1c56bc3b7ba94e87a785af4655ad9a0516950e 100644 (file)
--- a/busybox.c
+++ b/busybox.c
@@ -420,10 +420,15 @@ int main(int argc, char **argv)
        const struct BB_applet  *a              = applets;
 
 #ifdef BB_FEATURE_INSTALLER    
+       /* 
+        * This style of argument parsing doesn't scale well 
+        * in the event that busybox starts wanting more --options.
+        * If someone has a cleaner approach, by all means implement it.
+        */
        if (argc > 1 && (strcmp(argv[1], "--install") == 0)) {
                int use_symbolic_links = 0;
 
-               /* to use symlinks, or to not use symlinks... */
+               /* to use symlinks, or not to use symlinks... */
                if (argc > 2) {
                        if ((strcmp(argv[2], "-s") == 0)) { 
                                use_symbolic_links = 1;