reduce stack usage

diff --git a/main.c b/main.c
index f180c30b1826dbfbd136e6df2476a6e4b8aaddf8..3f16cd5d3bb56c364074972a1a491f4f19c8f4d2 100644 (file)
--- a/main.c
+++ b/main.c
@@ -98,7 +98,7 @@ retry:
 
        cur = buf;
        buf = proc->log_buf;
-       while ((cur = memchr(cur, '\n', len))) {
+       while (len > 0 && (cur = memchr(cur, '\n', len))) {
                *cur = 0;
 
                if (!proc->log_overflow)

diff --git a/proto-shell.c b/proto-shell.c
index c2a6d0011f227efe556f596c27deaa1736f3f421..3b5311ce17a228f55e4ef90eb415f9e40a823e7e 100644 (file)
--- a/proto-shell.c
+++ b/proto-shell.c
@@ -332,8 +332,8 @@ out:
 static int
 proto_shell_run_command(struct proto_shell_state *state, struct blob_attr **tb)
 {
-       char *argv[64];
-       char *env[32];
+       static char *argv[64];
+       static char *env[32];
 
        if (!tb[NOTIFY_COMMAND])
                goto error;

diff --git a/system-linux.c b/system-linux.c
index 44332a2b88d79af2b487b12a966673f9e9bff547..8b9189d27a2b974b043195a894999e5ef793b85e 100644 (file)
--- a/system-linux.c
+++ b/system-linux.c
@@ -101,7 +101,7 @@ static void system_set_sysctl(const char *path, const char *val)
 
 static void system_set_dev_sysctl(const char *path, const char *device, const char *val)
 {
-       char buf[256];
+       static char buf[256];
 
        snprintf(buf, sizeof(buf), path, val);
        system_set_sysctl(buf, val);
@@ -367,7 +367,7 @@ out:
  */
 void system_if_clear_state(struct device *dev)
 {
-       char buf[256];
+       static char buf[256];
        char *bridge;
 
        if (dev->external)