-fixing leaks/use after free

diff --git a/src/arm/arm_api.c b/src/arm/arm_api.c
index 16de889299b53ca9b52bed167ae892afff21d3ec..452dd34c4edd67190318fa86ff9101c3b67183db 100644 (file)
--- a/src/arm/arm_api.c
+++ b/src/arm/arm_api.c
@@ -763,8 +763,8 @@ handle_list_response (void *cls, const struct GNUNET_MessageHeader *msg)
       if (NULL == end)
       {
        GNUNET_break (0);
-       GNUNET_free (sc);
        sc->callback (sc->cls, GNUNET_NO, 0, NULL);
+       GNUNET_free (sc);
        return;
       }
       list[i] = pos;

diff --git a/src/gns/test_gns_dht_delegated_lookup.c b/src/gns/test_gns_dht_delegated_lookup.c
index 83fdf18730b0de924d32a3d11c3133a06e3430fa..3b097a3d52c3b706042e720721dcd842e073a8d9 100644 (file)
--- a/src/gns/test_gns_dht_delegated_lookup.c
+++ b/src/gns/test_gns_dht_delegated_lookup.c
@@ -224,6 +224,7 @@ put_dht(void *cls, int32_t success, const char *emsg)
   {
     GNUNET_log(GNUNET_ERROR_TYPE_ERROR, "Record serialization failed!\n");
     ok = 3;
+    GNUNET_free (nrb);
     return;
   }
   GNUNET_CRYPTO_hash(TEST_RECORD_NAME, strlen(TEST_RECORD_NAME), &name_hash);
@@ -244,6 +245,7 @@ put_dht(void *cls, int32_t success, const char *emsg)
                   DHT_OPERATION_TIMEOUT,
                   NULL,
                   NULL);
+  GNUNET_free (nrb);
   GNUNET_SCHEDULER_add_delayed(TIMEOUT, &finish_testing, NULL);
 }
 

diff --git a/src/util/crypto_rsa.c b/src/util/crypto_rsa.c
index 8f69e97fd13ab07b02c665a4ca49d16306847c38..2bb65f69b0e616520ed16d6418f86b53e9cbce99 100644 (file)
--- a/src/util/crypto_rsa.c
+++ b/src/util/crypto_rsa.c
@@ -808,6 +808,7 @@ GNUNET_CRYPTO_setup_hostkey (const char *cfg_name)
     pk = GNUNET_CRYPTO_rsa_key_create_from_file (fn);
     if (NULL != pk)
       GNUNET_CRYPTO_rsa_key_free (pk);
+    GNUNET_free (fn);
   }
   GNUNET_CONFIGURATION_destroy (cfg);
 }