remove some dead assignments, add a TODO comment

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>

diff --git a/archival/libunarchive/data_extract_all.c b/archival/libunarchive/data_extract_all.c
index c4ffe7ef818e31416734df6e552fa856b447f337..00e67d4055392b4b489c6f65eea066161bd2cddc 100644 (file)
--- a/archival/libunarchive/data_extract_all.c
+++ b/archival/libunarchive/data_extract_all.c
@@ -127,6 +127,7 @@ void FAST_FUNC data_extract_all(archive_handle_t *archive_handle)
                break;
        case S_IFLNK:
                /* Symlink */
+//TODO: what if file_header->link_target == NULL (say, corrupted tarball?)
                res = symlink(file_header->link_target, file_header->name);
                if ((res == -1)
                 && !(archive_handle->ah_flags & ARCHIVE_EXTRACT_QUIET)

diff --git a/editors/vi.c b/editors/vi.c
index 9b050e1157676f7a2f59b3b3f26a9e0d47eb9e7f..0f412c3627cf76de1dd72fb984b191bb41ec4ef8 100644 (file)
--- a/editors/vi.c
+++ b/editors/vi.c
@@ -2385,7 +2385,6 @@ static int file_write(char *fn, char *first, char *last)
                status_line_bold("No current filename");
                return -2;
        }
-       charcnt = 0;
        /* By popular request we do not open file with O_TRUNC,
         * but instead ftruncate() it _after_ successful write.
         * Might reduce amount of data lost on power fail etc.

diff --git a/networking/udhcp/dhcprelay.c b/networking/udhcp/dhcprelay.c
index e14325dcaaed3e465fab07dd138a17e8fdfc662d..d194a989b32f00879a3f7323e242f9ba0d78064d 100644 (file)
--- a/networking/udhcp/dhcprelay.c
+++ b/networking/udhcp/dhcprelay.c
@@ -175,7 +175,6 @@ static void pass_to_server(struct dhcp_packet *p, int packet_len, int client, in
                        struct sockaddr_in *client_addr, struct sockaddr_in *server_addr)
 {
        int res, type;
-       struct xid_item *item;
 
        /* check packet_type */
        type = get_dhcp_packet_type(p);
@@ -187,7 +186,7 @@ static void pass_to_server(struct dhcp_packet *p, int packet_len, int client, in
        }
 
        /* create new xid entry */
-       item = xid_add(p->xid, client_addr, client);
+       xid_add(p->xid, client_addr, client);
 
        /* forward request to LAN (server) */
        errno = 0;