x86: acpi: Remove redundant Offset (0x00)
authorAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Wed, 31 Oct 2018 17:14:08 +0000 (19:14 +0200)
committerBin Meng <bmeng.cn@gmail.com>
Tue, 6 Nov 2018 05:35:06 +0000 (13:35 +0800)
New ACPI assembler issues a warning:

board/intel/edison/dsdt.asl.tmp     13:     Offset (0x00),
Remark   2158 -                                       ^ Unnecessary/redundant use of Offset operator

Indeed, in the OperationRegion the offset is 0x00 by default.

Thus, drop unneeded Offset() use as suggested by ACPI assembler.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>
arch/x86/include/asm/arch-baytrail/acpi/global_nvs.asl
arch/x86/include/asm/arch-quark/acpi/global_nvs.asl
arch/x86/include/asm/arch-tangier/acpi/global_nvs.asl

index 9b8d1895eeed6eb3def36e984eaba7b752bc1c58..aaf87f4735ddfdbca5d281418e8429e6ea21965b 100644 (file)
@@ -8,7 +8,6 @@
 OperationRegion(GNVS, SystemMemory, ACPI_GNVS_ADDR, ACPI_GNVS_SIZE)
 Field(GNVS, ByteAcc, NoLock, Preserve)
 {
-       Offset (0x00),
        PCNT, 8,        /* processor count */
        IURE, 8,        /* internal UART enabled */
 }
index 44b9f12c7c7b2abbdb9a05a400613a3c9a980519..61602173f8e65c013351e763711715c0d1500dd4 100644 (file)
@@ -8,6 +8,5 @@
 OperationRegion(GNVS, SystemMemory, ACPI_GNVS_ADDR, ACPI_GNVS_SIZE)
 Field(GNVS, ByteAcc, NoLock, Preserve)
 {
-       Offset (0x00),
        PCNT, 8,        /* processor count */
 }
index a6296c2cb60e1266d67b5028f1bc4de7317135ac..895b807e96eaaf7c0d01d5d0e1233c90d1dd35cc 100644 (file)
@@ -10,6 +10,5 @@
 OperationRegion(GNVS, SystemMemory, ACPI_GNVS_ADDR, ACPI_GNVS_SIZE)
 Field(GNVS, ByteAcc, NoLock, Preserve)
 {
-    Offset (0x00),
     PCNT, 8,    /* processor count */
 }