bugfixes

diff --git a/BUGS b/BUGS
index d209717f554e7c96f4fcb3d6240eb1a85ca4aadf..e764e3cd99b22ca1f70e0cf57f53513e6a86a679 100644 (file)
--- a/BUGS
+++ b/BUGS
@@ -82,6 +82,22 @@ sane end-user should care about this codebase yet anyway.
     ==28393==    by 0x524473E: GNUNET_NETWORK_socket_create_from_accept (network.c:323)
     (rest of trace identical)
 
+  - [./transport/gnunet-service-transport.c:173]: (style) struct or union member 'TransportPlugin::rebuild' is never used
+  - [./transport/plugin_transport_tcp.c:391]: (style) struct or union member 'Plugin::address_update_task' is never used
+
+* FS:
+  - [./fs/gnunet-service-fs.c:208]: (style) struct or union member 'LocalGetContext::results_bf_size' is never used
+  - [./fs/gnunet-service-fs.c:501]: (style) struct or union member 'PendingRequest::used_pids_size' is never used
+  - [./fs/gnunet-service-fs.c:654]: (style) struct or union member 'ConnectedPeer::last_client_replies' is never used
+  - [./fs/gnunet-service-fs.c:669]: (style) struct or union member 'ConnectedPeer::avg_delay' is never used
+  - [./fs/gnunet-service-fs.c:675]: (style) struct or union member 'ConnectedPeer::avg_priority' is never used
+  - [./fs/gnunet-service-fs.c:688]: (style) struct or union member 'ConnectedPeer::pending_requests' is never used
+  - [./fs/gnunet-service-fs.c:694]: (style) struct or union member 'ConnectedPeer::last_p2p_replies_woff' is never used
+  - [./fs/gnunet-service-fs.c:700]: (style) struct or union member 'ConnectedPeer::last_client_replies_woff' is never used
+
+* TOPOLOGY:
+  - [./topology/gnunet-daemon-topology.c:94]: (style) struct or union member 'PeerList::last_hello_sent' is never used
+
 * DATASTORE:
   - mysql backend
   - postgres backend
@@ -100,6 +116,9 @@ sane end-user should care about this codebase yet anyway.
     to signal on PONG and have topology hook directly into transport to
     kill plaintext connections before they have a chance to become encrypted
     (may require minor hack in transport API)
+  - [./core/gnunet-service-core.c:469]: (style) struct or union member 'Neighbour::message_queue_size' is never used
+  - [./core/test_core_api_start_only.c:50]: (style) struct or union member 'PeerContext::id' is never used
+
 * PEERINFO:
   - have gnunet-peerinfo print actual host addresses again
   - add option to gnunet-peerinfo to modify trust value

diff --git a/src/datacache/datacache.c b/src/datacache/datacache.c
index bfd48ff63bf127b37db89888d18338909afb70f0..c8530055dc1dc9c3a324e69a5f1d4d6a2cd51fdf 100644 (file)
--- a/src/datacache/datacache.c
+++ b/src/datacache/datacache.c
@@ -34,11 +34,6 @@
 struct GNUNET_DATACACHE_Handle
 {
 
-  /**
-   * Our datastore plugin (NULL if not available).
-   */
-  struct DatastorePlugin *plugin;
-  
   /**
    * Bloomfilter to quickly tell if we don't have the content.
    */

diff --git a/src/datastore/test_datastore_api.c b/src/datastore/test_datastore_api.c
index 0e1ffe155da620b946c6b38384a50632a3956e27..605cb042d9f57b5f0d1d3ac7d03865e08536c9d9 100644 (file)
--- a/src/datastore/test_datastore_api.c
+++ b/src/datastore/test_datastore_api.c
@@ -118,7 +118,6 @@ struct CpsRunContext
   GNUNET_HashCode key;
   int i;
   int rid;
-  int *iptr;
   struct GNUNET_SCHEDULER_Handle *sched;
   const struct GNUNET_CONFIGURATION_Handle *cfg;
   void *data;

diff --git a/src/datastore/test_datastore_api_management.c b/src/datastore/test_datastore_api_management.c
index bcc5b5e85e9f8bded2334b3e03defa0d3b56527d..48daebb1df48b696801d9855211c92fd5723f029 100644 (file)
--- a/src/datastore/test_datastore_api_management.c
+++ b/src/datastore/test_datastore_api_management.c
@@ -111,7 +111,6 @@ struct CpsRunContext
   struct GNUNET_SCHEDULER_Handle *sched;
   const struct GNUNET_CONFIGURATION_Handle *cfg;
   void *data;
-  size_t size;
   enum RunPhase phase;
 };
 

diff --git a/src/fs/test_fs_download.c b/src/fs/test_fs_download.c
index 9b85e1ca1752a85c1feaca35047902eee9fc4817..04cd3e5d8e3f9655a9af40c69cecfafbc004cf7b 100644 (file)
--- a/src/fs/test_fs_download.c
+++ b/src/fs/test_fs_download.c
@@ -51,7 +51,6 @@
 struct PeerContext
 {
   struct GNUNET_CONFIGURATION_Handle *cfg;
-  struct GNUNET_PeerIdentity id;   
 #if START_ARM
   pid_t arm_pid;
 #endif

diff --git a/src/fs/test_fs_list_indexed.c b/src/fs/test_fs_list_indexed.c
index 46928044549e216040ce1891c9bfdf6ea04da0e9..868c9d71ad5f2ba4094b596da430cd0870b0f30c 100644 (file)
--- a/src/fs/test_fs_list_indexed.c
+++ b/src/fs/test_fs_list_indexed.c
@@ -55,7 +55,6 @@
 struct PeerContext
 {
   struct GNUNET_CONFIGURATION_Handle *cfg;
-  struct GNUNET_PeerIdentity id;   
 #if START_ARM
   pid_t arm_pid;
 #endif

diff --git a/src/fs/test_fs_namespace.c b/src/fs/test_fs_namespace.c
index 7a1a6f81e94885a46f9d3e297d6a61d76a2082b9..90286067d897a41d0403895a0d37d311fae13dd3 100644 (file)
--- a/src/fs/test_fs_namespace.c
+++ b/src/fs/test_fs_namespace.c
@@ -41,7 +41,6 @@ static struct GNUNET_FS_Handle *fs;
 struct PeerContext
 {
   struct GNUNET_CONFIGURATION_Handle *cfg;
-  struct GNUNET_PeerIdentity id;   
 #if START_ARM
   pid_t arm_pid;
 #endif

diff --git a/src/fs/test_fs_publish.c b/src/fs/test_fs_publish.c
index 9473cddb5212b9d2a190b9ae70b650cc9360b381..1b79b941dd6252eabb692f9490e201ee36aa7209 100644 (file)
--- a/src/fs/test_fs_publish.c
+++ b/src/fs/test_fs_publish.c
@@ -52,7 +52,6 @@
 struct PeerContext
 {
   struct GNUNET_CONFIGURATION_Handle *cfg;
-  struct GNUNET_PeerIdentity id;   
 #if START_ARM
   pid_t arm_pid;
 #endif

diff --git a/src/fs/test_fs_start_stop.c b/src/fs/test_fs_start_stop.c
index e25de8e7048eb35d118616bda4c01ba7697faea0..eac14b070c6fd0c1be37adb2e1805590676cb328 100644 (file)
--- a/src/fs/test_fs_start_stop.c
+++ b/src/fs/test_fs_start_stop.c
@@ -38,7 +38,6 @@ static struct PeerContext p1;
 struct PeerContext
 {
   struct GNUNET_CONFIGURATION_Handle *cfg;
-  struct GNUNET_PeerIdentity id;   
 #if START_ARM
   pid_t arm_pid;
 #endif

diff --git a/src/fs/test_fs_unindex.c b/src/fs/test_fs_unindex.c
index c2fc8913b78cf9428d892826210002aa6e5f69fe..eb10c1db96a16a759e1e801990c0f7410cab1dd1 100644 (file)
--- a/src/fs/test_fs_unindex.c
+++ b/src/fs/test_fs_unindex.c
@@ -51,7 +51,6 @@
 struct PeerContext
 {
   struct GNUNET_CONFIGURATION_Handle *cfg;
-  struct GNUNET_PeerIdentity id;   
 #if START_ARM
   pid_t arm_pid;
 #endif

diff --git a/src/hostlist/test_gnunet_daemon_hostlist.c b/src/hostlist/test_gnunet_daemon_hostlist.c
index 2c3647190e7963d34ce2f45466d3e2ee0649d22b..d71340377cf15d07e9a2521ddbfbca11654a343c 100644 (file)
--- a/src/hostlist/test_gnunet_daemon_hostlist.c
+++ b/src/hostlist/test_gnunet_daemon_hostlist.c
@@ -44,8 +44,6 @@ static struct GNUNET_SCHEDULER_Handle *sched;
 struct PeerContext
 {
   struct GNUNET_CONFIGURATION_Handle *cfg;
-  struct GNUNET_CORE_Handle *ch;
-  struct GNUNET_PeerIdentity id; 
   struct GNUNET_TRANSPORT_Handle *th;
   struct GNUNET_MessageHeader *hello;
 #if START_ARM

diff --git a/src/util/container_heap.c b/src/util/container_heap.c
index efe968e82f4098ff2266a66130ab06d1bcbc07c4..4709d97a6e820ba2d26a92b4383869bc02268fb0 100644 (file)
--- a/src/util/container_heap.c
+++ b/src/util/container_heap.c
@@ -28,19 +28,7 @@
 #include "gnunet_protocols.h"
 #include "gnunet_util_lib.h"
 
-/*
- * Struct that is stored in hashmap, pointers to
- * locations in min_heap and max_heap.
- */
-struct GNUNET_CONTAINER_heap_info
-{
-  struct GNUNET_CONTAINER_heap_node *min_loc;
-
-  struct GNUNET_CONTAINER_heap_node *max_loc;
-
-};
-
-/*
+/**
  * Generic heap node structure, contains pointer to parent
  * left child, right child, and actual neighbor.
  */
@@ -211,7 +199,7 @@ static struct GNUNET_CONTAINER_heap_node *
 getPos (struct GNUNET_CONTAINER_Heap *root, unsigned int pos)
 {
   struct GNUNET_CONTAINER_heap_node *ret;
-  int i;
+  unsigned int i;
 
   ret = NULL;
   if (pos > root->size)