Spare some string copies

diff --git a/src/content_sao.cpp b/src/content_sao.cpp
index 1f7323c9c8c73ae281e4f832f0322cdf2eec389d..b644bdff77f799f9d1a19cd68d884b1884d1d494 100644 (file)
--- a/src/content_sao.cpp
+++ b/src/content_sao.cpp
@@ -541,13 +541,13 @@ void LuaEntitySAO::setAnimation(v2f frame_range, float frame_speed, float frame_
        m_animation_sent = false;
 }
 
-void LuaEntitySAO::setBonePosition(std::string bone, v3f position, v3f rotation)
+void LuaEntitySAO::setBonePosition(const std::string &bone, v3f position, v3f rotation)
 {
        m_bone_position[bone] = core::vector2d<v3f>(position, rotation);
        m_bone_position_sent = false;
 }
 
-void LuaEntitySAO::setAttachment(int parent_id, std::string bone, v3f position, v3f rotation)
+void LuaEntitySAO::setAttachment(int parent_id, const std::string &bone, v3f position, v3f rotation)
 {
        // Attachments need to be handled on both the server and client.
        // If we just attach on the server, we can only copy the position of the parent. Attachments
@@ -1142,14 +1142,14 @@ void PlayerSAO::setAnimation(v2f frame_range, float frame_speed, float frame_ble
        m_animation_sent = false;
 }
 
-void PlayerSAO::setBonePosition(std::string bone, v3f position, v3f rotation)
+void PlayerSAO::setBonePosition(const std::string &bone, v3f position, v3f rotation)
 {
        // store these so they can be updated to clients
        m_bone_position[bone] = core::vector2d<v3f>(position, rotation);
        m_bone_position_sent = false;
 }
 
-void PlayerSAO::setAttachment(int parent_id, std::string bone, v3f position, v3f rotation)
+void PlayerSAO::setAttachment(int parent_id, const std::string &bone, v3f position, v3f rotation)
 {
        // Attachments need to be handled on both the server and client.
        // If we just attach on the server, we can only copy the position of the parent. Attachments

diff --git a/src/content_sao.h b/src/content_sao.h
index 4a8c70e16b9061da26cf922a097ff8b9178d219b..05b5fa7e1a1bfa0981499c5b001632761c2c5e27 100644 (file)
--- a/src/content_sao.h
+++ b/src/content_sao.h
@@ -59,8 +59,8 @@ public:
        s16 getHP() const;
        void setArmorGroups(const ItemGroupList &armor_groups);
        void setAnimation(v2f frame_range, float frame_speed, float frame_blend);
-       void setBonePosition(std::string bone, v3f position, v3f rotation);
-       void setAttachment(int parent_id, std::string bone, v3f position, v3f rotation);
+       void setBonePosition(const std::string &bone, v3f position, v3f rotation);
+       void setAttachment(int parent_id, const std::string &bone, v3f position, v3f rotation);
        ObjectProperties* accessObjectProperties();
        void notifyObjectPropertiesModified();
        /* LuaEntitySAO-specific */
@@ -193,8 +193,8 @@ public:
        void setBreath(u16 breath);
        void setArmorGroups(const ItemGroupList &armor_groups);
        void setAnimation(v2f frame_range, float frame_speed, float frame_blend);
-       void setBonePosition(std::string bone, v3f position, v3f rotation);
-       void setAttachment(int parent_id, std::string bone, v3f position, v3f rotation);
+       void setBonePosition(const std::string &bone, v3f position, v3f rotation);
+       void setAttachment(int parent_id, const std::string &bone, v3f position, v3f rotation);
        ObjectProperties* accessObjectProperties();
        void notifyObjectPropertiesModified();
        void setNametagColor(video::SColor color);