Fix a bug that creapt in recently with substitution subprinting, and add

a test for it.

diff --git a/editors/sed.c b/editors/sed.c
index da15c4d06d4b419d37b9c8391474532873a00881..a5a9d41a0769629787904ddf0b877c6fa1a52799 100644 (file)
--- a/editors/sed.c
+++ b/editors/sed.c
@@ -914,7 +914,6 @@ static void process_file(FILE * file)
 #endif
                                        /* we print the pattern_space once, unless we were told to be quiet */
                                        substituted |= do_subst_command(sed_cmd, &pattern_space);
-
 #ifdef CONFIG_FEATURE_SED_EMBEDED_NEWLINE
                                        /* undo HACK: escape newlines twice so regex can match them */
                                        {
@@ -930,10 +929,10 @@ static void process_file(FILE * file)
                                                        || (sed_cmd->next->cmd != 's'))) {
                                                force_print = 1;
                                        }
-
                                        /* we also print the line if we were given the 'p' flag
                                         * (this is quite possibly the second printing) */
-                                       if ((sed_cmd->sub_p) && altered) {
+//                                     if ((sed_cmd->sub_p) && (!altered || substituted)) {
+                                       if ((sed_cmd->sub_p) && (altered || substituted)) {
                                                puts(pattern_space);
                                        }
                                        break;

diff --git a/testsuite/sed/sed-subst-subprint b/testsuite/sed/sed-subst-subprint
new file mode 100644 (file)
index 0000000..24f8bad
--- /dev/null
+++ b/testsuite/sed/sed-subst-subprint
@@ -0,0 +1,9 @@
+busybox sed 's/foo/bar/p'>output <<EOF
+foo
+bar
+EOF
+cmp -s output - <<EOF
+bar
+bar
+bar
+EOF