-always check that WE can execute

diff --git a/src/util/os_installation.c b/src/util/os_installation.c
index c0b7c8583638c5b13692c66ea098f327965e4cd4..ee4257ca5b931fcf77c0ce3d9064c67a57487665 100644 (file)
--- a/src/util/os_installation.c
+++ b/src/util/os_installation.c
@@ -487,6 +487,13 @@ GNUNET_OS_check_helper_binary (const char *binary)
          binary);
     return GNUNET_SYSERR;
   }
+  if (0 != ACCESS (p, X_OK))
+  {
+    LOG (GNUNET_ERROR_TYPE_WARNING, _("access (%s, X_OK) failed: %s\n"), p,
+         STRERROR (errno));
+    GNUNET_free (p);
+    return GNUNET_SYSERR;
+  }
   if (0 != STAT (p, &statbuf))
   {
     LOG (GNUNET_ERROR_TYPE_WARNING, _("stat (%s) failed: %s\n"), p,
@@ -500,11 +507,6 @@ GNUNET_OS_check_helper_binary (const char *binary)
     GNUNET_free (p);
     return GNUNET_YES;
   }
-  if (0 == ACCESS (p, X_OK))
-  {
-    GNUNET_free (p);
-    return GNUNET_NO;
-  }
   GNUNET_free (p);
   return GNUNET_SYSERR;
 #else