sf: Use unsigned type for buffers
authorSimon Glass <sjg@chromium.org>
Mon, 11 Mar 2013 06:08:13 +0000 (06:08 +0000)
committerSimon Glass <sjg@chromium.org>
Tue, 19 Mar 2013 15:45:38 +0000 (08:45 -0700)
The verify code is broken on archs with signed char. Fix it.

Signed-off-by: Simon Glass <sjg@chromium.org>
common/cmd_sf.c

index b1753587d3c92f1273e66acab040bad9efca5761..3f0d414954c3e317507b899ec61391d07b38a77b 100644 (file)
@@ -369,8 +369,8 @@ static void spi_test_next_stage(struct test_info *test)
  * @param vbuf         Verification buffer
  * @return 0 if ok, -1 on error
  */
-static int spi_flash_test(struct spi_flash *flash, char *buf, ulong len,
-                          ulong offset, char *vbuf)
+static int spi_flash_test(struct spi_flash *flash, uint8_t *buf, ulong len,
+                          ulong offset, uint8_t *vbuf)
 {
        struct test_info test;
        int i;
@@ -431,9 +431,9 @@ static int do_spi_flash_test(int argc, char * const argv[])
 {
        unsigned long offset;
        unsigned long len;
-       char *buf = (char *)CONFIG_SYS_TEXT_BASE;
+       uint8_t *buf = (uint8_t *)CONFIG_SYS_TEXT_BASE;
        char *endp;
-       char *vbuf;
+       uint8_t *vbuf;
        int ret;
 
        offset = simple_strtoul(argv[1], &endp, 16);