binman: Use tools.Run() to run objdump
authorSimon Glass <sjg@chromium.org>
Sat, 24 Aug 2019 13:22:52 +0000 (07:22 -0600)
committerSimon Glass <sjg@chromium.org>
Tue, 15 Oct 2019 14:40:02 +0000 (08:40 -0600)
At present this command silently fails if something goes wrong. Use the
tools.Run() function instead, since it reports errors.

Signed-off-by: Simon Glass <sjg@chromium.org>
tools/binman/elf.py

index 66cfe796a22ac391b28f67bbb36860028eadd89b..7bc7cf61b5d83721cbd73e093fd40d6619889520 100644 (file)
@@ -49,7 +49,7 @@ def GetSymbols(fname, patterns):
           key: Name of symbol
           value: Hex value of symbol
     """
-    stdout = command.Output('objdump', '-t', fname, raise_on_error=False)
+    stdout = tools.Run('objdump', '-t', fname)
     lines = stdout.splitlines()
     if patterns:
         re_syms = re.compile('|'.join(patterns))