Fix cc field in classic audience
authorChocobozzz <me@florianbigard.com>
Fri, 25 May 2018 09:17:41 +0000 (11:17 +0200)
committerChocobozzz <me@florianbigard.com>
Fri, 25 May 2018 09:17:41 +0000 (11:17 +0200)
server/lib/activitypub/actor.ts
server/lib/activitypub/fetch.ts [deleted file]
server/lib/activitypub/process/process-accept.ts
server/lib/activitypub/send/misc.ts

index 4c336f26ebb2a4418e5c5c18119664b7313629b6..f27733418fc83bc176394a0a6bd3f73f92c94742 100644 (file)
@@ -19,6 +19,8 @@ import { ActorModel } from '../../models/activitypub/actor'
 import { AvatarModel } from '../../models/avatar/avatar'
 import { ServerModel } from '../../models/server/server'
 import { VideoChannelModel } from '../../models/video/video-channel'
+import { JobQueue } from '../job-queue'
+import { getServerActor } from '../../helpers/utils'
 
 // Set account keys, this could be long so process after the account creation and do not block the client
 function setAsyncActorKeys (actor: ActorModel) {
@@ -169,6 +171,21 @@ async function fetchAvatarIfExists (actorJSON: ActivityPubActor) {
   return undefined
 }
 
+async function addFetchOutboxJob (actor: ActorModel) {
+  // Don't fetch ourselves
+  const serverActor = await getServerActor()
+  if (serverActor.id === actor.id) {
+    logger.error('Cannot fetch our own outbox!')
+    return undefined
+  }
+
+  const payload = {
+    uris: [ actor.outboxUrl ]
+  }
+
+  return JobQueue.Instance.createJob({ type: 'activitypub-http-fetcher', payload })
+}
+
 export {
   getOrCreateActorAndServerAndModel,
   buildActorInstance,
@@ -176,7 +193,8 @@ export {
   fetchActorTotalItems,
   fetchAvatarIfExists,
   updateActorInstance,
-  updateActorAvatarInstance
+  updateActorAvatarInstance,
+  addFetchOutboxJob
 }
 
 // ---------------------------------------------------------------------------
diff --git a/server/lib/activitypub/fetch.ts b/server/lib/activitypub/fetch.ts
deleted file mode 100644 (file)
index a8eefff..0000000
+++ /dev/null
@@ -1,23 +0,0 @@
-import { logger } from '../../helpers/logger'
-import { getServerActor } from '../../helpers/utils'
-import { ActorModel } from '../../models/activitypub/actor'
-import { JobQueue } from '../job-queue'
-
-async function addFetchOutboxJob (actor: ActorModel) {
-  // Don't fetch ourselves
-  const serverActor = await getServerActor()
-  if (serverActor.id === actor.id) {
-    logger.error('Cannot fetch our own outbox!')
-    return undefined
-  }
-
-  const payload = {
-    uris: [ actor.outboxUrl ]
-  }
-
-  return JobQueue.Instance.createJob({ type: 'activitypub-http-fetcher', payload })
-}
-
-export {
-  addFetchOutboxJob
-}
index c55b57820e698fcc635d2f4e469e6de17c5ecd69..046370b79dc0124366276903110d43c7657ff995 100644 (file)
@@ -2,7 +2,7 @@ import { ActivityAccept } from '../../../../shared/models/activitypub'
 import { getActorUrl } from '../../../helpers/activitypub'
 import { ActorModel } from '../../../models/activitypub/actor'
 import { ActorFollowModel } from '../../../models/activitypub/actor-follow'
-import { addFetchOutboxJob } from '../fetch'
+import { addFetchOutboxJob } from '../actor'
 
 async function processAcceptActivity (activity: ActivityAccept, inboxActor?: ActorModel) {
   if (inboxActor === undefined) throw new Error('Need to accept on explicit inbox.')
index b2d968c9cc4c6124651e44ed6d4c835c558f2baf..646aa9f0a25654f8ff78db621a701215242da671 100644 (file)
@@ -139,9 +139,7 @@ async function getActorsInvolvedInVideo (video: VideoModel, t: Transaction) {
 }
 
 async function getAudience (actorSender: ActorModel, t: Transaction, isPublic = true) {
-  const followerInboxUrls = await actorSender.getFollowerSharedInboxUrls(t)
-
-  return buildAudience(followerInboxUrls, isPublic)
+  return buildAudience([ actorSender.followersUrl ], isPublic)
 }
 
 function buildAudience (followerInboxUrls: string[], isPublic = true) {