Remove unused function in ReliablePacketBuffer
authorsfan5 <sfan5@live.de>
Thu, 15 Aug 2019 18:47:32 +0000 (20:47 +0200)
committersfan5 <sfan5@live.de>
Fri, 16 Aug 2019 18:03:53 +0000 (20:03 +0200)
src/network/connection.cpp
src/network/connection.h

index 8eb91d45eaa75829839e4738ffc79c92114d1c24..0bc13a2f0f25f23a64d13bc6ee152dcc078e2ba4 100644 (file)
@@ -182,19 +182,12 @@ u32 ReliablePacketBuffer::size()
        return m_list.size();
 }
 
-bool ReliablePacketBuffer::containsPacket(u16 seqnum)
-{
-       return !(findPacket(seqnum) == m_list.end());
-}
-
 RPBSearchResult ReliablePacketBuffer::findPacket(u16 seqnum)
 {
        std::list<BufferedPacket>::iterator i = m_list.begin();
        for(; i != m_list.end(); ++i)
        {
                u16 s = readU16(&(i->data[BASE_HEADER_SIZE+1]));
-               /*dout_con<<"findPacket(): finding seqnum="<<seqnum
-                               <<", comparing to s="<<s<<std::endl;*/
                if (s == seqnum)
                        break;
        }
index 5b1902debd149b70f02b0f7cc7a2716883dd1ee5..057bd39f66a93acef96a46b6ed15ce682af158fb 100644 (file)
@@ -252,13 +252,12 @@ public:
 
        void print();
        bool empty();
-       bool containsPacket(u16 seqnum);
        RPBSearchResult notFound();
        u32 size();
 
 
 private:
-       RPBSearchResult findPacket(u16 seqnum);
+       RPBSearchResult findPacket(u16 seqnum); // does not perform locking
 
        std::list<BufferedPacket> m_list;