adc: stm32-adc: Fix warnings when compiling with W=1
authorPatrick Delaunay <patrick.delaunay@st.com>
Fri, 21 Jun 2019 13:26:44 +0000 (15:26 +0200)
committerPatrick Delaunay <patrick.delaunay@st.com>
Fri, 12 Jul 2019 09:50:55 +0000 (11:50 +0200)
This patch solves the following warnings:

drivers/adc/stm32-adc.c: In function 'stm32_adc_chan_of_init':
warning: comparison between signed and unsigned integer expressions [-Wsign-compare]
  if (num_channels > adc->cfg->max_channels) {
                   ^
Signed-off-by: Patrice Chotard <patrice.chotard@st.com>
Signed-off-by: Patrick Delaunay <patrick.delaunay@st.com>
Acked-by: Fabrice Gasnier <fabrice.gasnier@st.com>
drivers/adc/stm32-adc.c

index e108062f2feed29c81a9253362b207b747141931..029338e4af6093ad0fa4f9d70a6e2853bed5301d 100644 (file)
@@ -163,15 +163,16 @@ static int stm32_adc_chan_of_init(struct udevice *dev)
        struct adc_uclass_platdata *uc_pdata = dev_get_uclass_platdata(dev);
        struct stm32_adc *adc = dev_get_priv(dev);
        u32 chans[STM32_ADC_CH_MAX];
-       int i, num_channels, ret;
+       unsigned int i, num_channels;
+       int ret;
 
        /* Retrieve single ended channels listed in device tree */
-       num_channels = dev_read_size(dev, "st,adc-channels");
-       if (num_channels < 0) {
-               dev_err(dev, "can't get st,adc-channels: %d\n", num_channels);
-               return num_channels;
+       ret = dev_read_size(dev, "st,adc-channels");
+       if (ret < 0) {
+               dev_err(dev, "can't get st,adc-channels: %d\n", ret);
+               return ret;
        }
-       num_channels /= sizeof(u32);
+       num_channels = ret / sizeof(u32);
 
        if (num_channels > adc->cfg->max_channels) {
                dev_err(dev, "too many st,adc-channels: %d\n", num_channels);