CRYPTO_malloc(), CRYPTO_realloc() and variants of them should return NULL

if the give size is 0.

This is a thought that came up in PR 751.

diff --git a/crypto/mem.c b/crypto/mem.c
index 0df0a2a5491d3df9b2c7cbd1d09503b9f2500e41..6b38f4ad2a16ce7512820c6dfb7e1fa4b791469f 100644 (file)
--- a/crypto/mem.c
+++ b/crypto/mem.c
@@ -175,7 +175,7 @@ void *CRYPTO_malloc_locked(int num, const char *file, int line)
        void *ret = NULL;
        extern unsigned char cleanse_ctr;
 
-       if (num < 0) return NULL;
+       if (num <= 0) return NULL;
 
        allow_customize = 0;
        if (malloc_debug_func != NULL)
@@ -216,7 +216,7 @@ void *CRYPTO_malloc(int num, const char *file, int line)
        void *ret = NULL;
        extern unsigned char cleanse_ctr;
 
-       if (num < 0) return NULL;
+       if (num <= 0) return NULL;
 
        allow_customize = 0;
        if (malloc_debug_func != NULL)
@@ -247,7 +247,7 @@ void *CRYPTO_realloc(void *str, int num, const char *file, int line)
        if (str == NULL)
                return CRYPTO_malloc(num, file, line);
 
-       if (num < 0) return NULL;
+       if (num <= 0) return NULL;
 
        if (realloc_debug_func != NULL)
                realloc_debug_func(str, NULL, num, file, line, 0);