travis-ci: use correct exit code on errors
authorStephen Warren <swarren@nvidia.com>
Wed, 26 Oct 2016 17:05:32 +0000 (11:05 -0600)
committerTom Rini <trini@konsulko.com>
Sat, 29 Oct 2016 02:10:43 +0000 (22:10 -0400)
The phrase "if [ $? -ne 0 ]; then exit $?; fi" doesn't work correctly;
by the time the "exit" statement runs, $? has already been over-written
by the result of the [ command. Fix this by explicitly storing $? and
then using that stored value in both the test and the error-case exit
statement.

This change also converts from textual comparison to integer comparison,
since the exit code is an integer and there's no need to convert it to
a string for comparison.

Signed-off-by: Stephen Warren <swarren@nvidia.com>
Reviewed-by: Heiko Schocher <hs@denx.de>
.travis.yml

index f91e1bc271fe4f1702255954ce91cff6a334ff47..33685ce14777065e4476ebc3ea70a754073b3649 100644 (file)
@@ -70,11 +70,12 @@ script:
  - if [[ "${BUILDMAN}" != "" ]]; then
      set +e;
      tools/buildman/buildman ${BUILDMAN};
-     if [[ "$?" == "0" || "$?" == "129" ]]; then
+     ret=$?;
+     if [[ $ret -eq 0 || $ret -eq 129 ]]; then
        exit 0;
      else
-       exit $?;
-     fi
+       exit $ret;
+     fi;
    fi
 
 matrix: