hdparm: paranoia-induced fix against theoretical div-by-0 case
authorDenis Vlasenko <vda.linux@googlemail.com>
Fri, 28 Sep 2007 13:41:41 +0000 (13:41 -0000)
committerDenis Vlasenko <vda.linux@googlemail.com>
Fri, 28 Sep 2007 13:41:41 +0000 (13:41 -0000)
miscutils/hdparm.c

index 906dd7a0c2beef51836c2c368d94f32b84aec504..cb6db78cd2b6ea25ee41d732717bf37e9a5a999c 100644 (file)
@@ -1378,8 +1378,8 @@ static void print_timing(unsigned m, unsigned elapsed_us)
 
        printf("%5u MB in %u.%02u seconds = %u kB/s\n",
                m, sec, hs,
-               /* + 1 prevents div-by-0 */
-               (unsigned) ((unsigned long long)m * (1024 * 1000000) / (elapsed_us + 1))
+               /* "| 1" prevents div-by-0 */
+               (unsigned) ((unsigned long long)m * (1024 * 1000000) / (elapsed_us | 1))
                // ~= (m * 1024) / (elapsed_us / 1000000)
                // = kb / elapsed_sec
        );