net: phy: dp83867: Add SGMII helper for configuration
authorDan Murphy <dmurphy@ti.com>
Mon, 2 May 2016 20:46:02 +0000 (15:46 -0500)
committerJoe Hershberger <joe.hershberger@ni.com>
Tue, 24 May 2016 16:42:05 +0000 (11:42 -0500)
The code assumed that if the interface is not RGMII configured
then it must be SGMII configured.  This device has the ability
to support most of the MII interfaces.  Therefore add the
helper for SGMII and only configure the device if the interface is
configured for SGMII.

Signed-off-by: Dan Murphy <dmurphy@ti.com>
Reviewed-by: Mugunthan V N <mugunthanvnm@ti.com>
Reviewed-by: Michal Simek <michal.simek@xilinx.com>
Acked-by: Joe Hershberger <joe.hershberger@ni.com>
drivers/net/phy/ti.c

index 4c19353f6628dec879c63947101ab97d8db369f2..c55dd973f4c3ea6d8d1e2cc2966e4f233d37d920 100644 (file)
@@ -221,7 +221,7 @@ static int dp83867_config(struct phy_device *phydev)
                        (dp83867->fifo_depth << DP83867_PHYCR_FIFO_DEPTH_SHIFT));
                if (ret)
                        goto err_out;
-       } else {
+       } else if (phy_interface_is_sgmii(phydev)) {
                phy_write(phydev, MDIO_DEVAD_NONE, MII_BMCR,
                          (BMCR_ANENABLE | BMCR_FULLDPLX | BMCR_SPEED1000));