luci-app-ddns: make param opt, optional, add myself as maintainer

Currently these params should be optional but in the current script then are required for any configuration to save. We add an "optional" boolean value to the validate function so that we can make this pram optional as it should be. Also adds me as maintainer

Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>

diff --git a/applications/luci-app-ddns/Makefile b/applications/luci-app-ddns/Makefile
index 886b266b046c9c4c1a103e9857cc48217b0d8e65..72951895187a83e39b37e7688bc6da8bf5ec11c3 100644 (file)
--- a/applications/luci-app-ddns/Makefile
+++ b/applications/luci-app-ddns/Makefile
@@ -16,10 +16,11 @@ PKG_VERSION:=2.4.9
 
 # Release == build
 # increase on changes of translation files
-PKG_RELEASE:=4
+PKG_RELEASE:=5
 
 PKG_LICENSE:=Apache-2.0
-PKG_MAINTAINER:=Christian Schoenebeck <christian.schoenebeck@gmail.com>
+PKG_MAINTAINER:=Christian Schoenebeck <christian.schoenebeck@gmail.com>, \
+                               Ansuel Smith <ansuelsmth@gmail.com>
 
 # LuCI specific settings
 LUCI_TITLE:=LuCI Support for Dynamic DNS Client (ddns-scripts)

diff --git a/applications/luci-app-ddns/luasrc/model/cbi/ddns/detail.lua b/applications/luci-app-ddns/luasrc/model/cbi/ddns/detail.lua
index 10d39c7183334ff46d80fcddaecbf919bd9ad158..eb2159076ef230c1c34545e191f7a9dec8f5f848 100644 (file)
--- a/applications/luci-app-ddns/luasrc/model/cbi/ddns/detail.lua
+++ b/applications/luci-app-ddns/luasrc/model/cbi/ddns/detail.lua
@@ -172,7 +172,7 @@ local function _option_used(option, urlscript)
 end
 
 -- function to verify if option is valid
-local function _option_validate(self, value)
+local function _option_validate(self, value, optional)
        -- section is globally defined here be calling agrument (see above)
        local fusev6 = usev6:formvalue(section) or "0"
        local fsvc4  = svc4:formvalue(section) or "-"
@@ -204,6 +204,7 @@ local function _option_validate(self, value)
        if used < 1 then return "" end
        -- needed but no data then return error
        if not value or (#value == 0) then
+               if optional then return nil end                                          
                return nil, err_tab_basic(self) .. translate("missing / required")
        end
        return value
@@ -513,18 +514,18 @@ pe = ns:taboption("basic", Value, "param_enc",
                translate("Optional Encoded Parameter"),
                translate("Optional: Replaces [PARAMENC] in Update-URL (URL-encoded)") )
 function pe.validate(self, value)
-       return _option_validate(self, value)
+       return _option_validate(self, value, true)
 end
 function pe.parse(self, section, novld)
        DDNS.value_parse(self, section, novld)
 end
 
--- IPv4/IPv6 - param_enc -- ###################################################
+-- IPv4/IPv6 - param_opt -- ###################################################
 po = ns:taboption("basic", Value, "param_opt",
                translate("Optional Parameter"),
                translate("Optional: Replaces [PARAMOPT] in Update-URL (NOT URL-encoded)") )
 function po.validate(self, value)
-       return _option_validate(self, value)
+       return _option_validate(self, value, true)
 end
 function po.parse(self, section, novld)
        DDNS.value_parse(self, section, novld)