cm-t35: fix Ethernet reset timing
authorIgor Grinberg <grinberg@compulab.co.il>
Mon, 2 Apr 2012 20:12:58 +0000 (20:12 +0000)
committerAlbert ARIBAUD <albert.u.boot@aribaud.net>
Mon, 16 Apr 2012 12:47:58 +0000 (14:47 +0200)
The reset_net_chip() function has wrong timings for the reset pulse.

This appeared to work until:
0607e2b (ARMV7: OMAP: Write more than 1 byte at a time in i2c_write)

Fix the Ethernet support by introducing right timings.

Signed-off-by: Igor Grinberg <grinberg@compulab.co.il>
board/cm_t35/cm_t35.c

index 0a049944d7a5fbd1773659189a36dc3b15d50719..7af1f41af2f9932590ebe4c82ffa76fbe554c697 100644 (file)
@@ -356,16 +356,17 @@ static void reset_net_chip(void)
 {
        /* Set GPIO1 of TPS65930 as output */
        twl4030_i2c_write_u8(TWL4030_CHIP_GPIO, 0x02,
-                            TWL4030_BASEADD_GPIO+0x03);
+                               TWL4030_BASEADD_GPIO + 0x03);
        /* Send a pulse on the GPIO pin */
        twl4030_i2c_write_u8(TWL4030_CHIP_GPIO, 0x02,
-                            TWL4030_BASEADD_GPIO+0x0C);
+                               TWL4030_BASEADD_GPIO + 0x0C);
        udelay(1);
        twl4030_i2c_write_u8(TWL4030_CHIP_GPIO, 0x02,
-                            TWL4030_BASEADD_GPIO+0x09);
-       udelay(1);
+                               TWL4030_BASEADD_GPIO + 0x09);
+       mdelay(40);
        twl4030_i2c_write_u8(TWL4030_CHIP_GPIO, 0x02,
-                            TWL4030_BASEADD_GPIO+0x0C);
+                               TWL4030_BASEADD_GPIO + 0x0C);
+       mdelay(1);
 }
 #else
 static inline void reset_net_chip(void) {}