dm: pci: Break out the common region display code
authorSimon Glass <sjg@chromium.org>
Mon, 29 Feb 2016 22:25:35 +0000 (15:25 -0700)
committerSimon Glass <sjg@chromium.org>
Mon, 14 Mar 2016 21:34:50 +0000 (15:34 -0600)
Each region is displayed in almost the same way. Break out this common code
into its own function.

Signed-off-by: Simon Glass <sjg@chromium.org>
Tested-by: Stephen Warren <swarren@nvidia.com>
drivers/pci/pci_auto_common.c

index 85c419e6f400988ebb832c103690724dc8630d5b..677f094b419f4557ec7ef77001694223bcbd36db 100644 (file)
@@ -62,6 +62,17 @@ int pciauto_region_allocate(struct pci_region *res, pci_size_t size,
        return -1;
 }
 
+static void pciauto_show_region(const char *name, struct pci_region *region)
+{
+       pciauto_region_init(region);
+       debug("PCI Autoconfig: Bus %s region: [%llx-%llx],\n"
+             "\t\tPhysical Memory [%llx-%llxx]\n", name,
+             (unsigned long long)region->bus_start,
+             (unsigned long long)(region->bus_start + region->size - 1),
+             (unsigned long long)region->phys_start,
+             (unsigned long long)(region->phys_start + region->size - 1));
+}
+
 void pciauto_config_init(struct pci_controller *hose)
 {
        int i;
@@ -91,38 +102,10 @@ void pciauto_config_init(struct pci_controller *hose)
        }
 
 
-       if (hose->pci_mem) {
-               pciauto_region_init(hose->pci_mem);
-
-               debug("PCI Autoconfig: Bus Memory region: [0x%llx-0x%llx],\n"
-                      "\t\tPhysical Memory [%llx-%llxx]\n",
-                   (u64)hose->pci_mem->bus_start,
-                   (u64)(hose->pci_mem->bus_start + hose->pci_mem->size - 1),
-                   (u64)hose->pci_mem->phys_start,
-                   (u64)(hose->pci_mem->phys_start + hose->pci_mem->size - 1));
-       }
-
-       if (hose->pci_prefetch) {
-               pciauto_region_init(hose->pci_prefetch);
-
-               debug("PCI Autoconfig: Bus Prefetchable Mem: [0x%llx-0x%llx],\n"
-                      "\t\tPhysical Memory [%llx-%llx]\n",
-                   (u64)hose->pci_prefetch->bus_start,
-                   (u64)(hose->pci_prefetch->bus_start +
-                           hose->pci_prefetch->size - 1),
-                   (u64)hose->pci_prefetch->phys_start,
-                   (u64)(hose->pci_prefetch->phys_start +
-                           hose->pci_prefetch->size - 1));
-       }
-
-       if (hose->pci_io) {
-               pciauto_region_init(hose->pci_io);
-
-               debug("PCI Autoconfig: Bus I/O region: [0x%llx-0x%llx],\n"
-                      "\t\tPhysical Memory: [%llx-%llx]\n",
-                   (u64)hose->pci_io->bus_start,
-                   (u64)(hose->pci_io->bus_start + hose->pci_io->size - 1),
-                   (u64)hose->pci_io->phys_start,
-                   (u64)(hose->pci_io->phys_start + hose->pci_io->size - 1));
-       }
+       if (hose->pci_mem)
+               pciauto_show_region("Memory", hose->pci_mem);
+       if (hose->pci_prefetch)
+               pciauto_show_region("Prefetchable Mem", hose->pci_prefetch);
+       if (hose->pci_io)
+               pciauto_show_region("I/O", hose->pci_io);
 }