hush: renumber PIPE_foo, make PIPE_SEQ = 0
authorDenys Vlasenko <vda.linux@googlemail.com>
Tue, 8 Nov 2016 19:35:53 +0000 (20:35 +0100)
committerDenys Vlasenko <vda.linux@googlemail.com>
Tue, 8 Nov 2016 19:35:53 +0000 (20:35 +0100)
PIPE_SEQ is used most often, having it zero makes code smaller:

function                                             old     new   delta
done_word                                            719     707     -12
parse_stream                                        2546    2531     -15

Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
shell/hush.c

index 5a36a7692f8458f933a7f540c2efa24805bf33cf..57252a17a77b9a2a7a2f45419525315b6402b98d 100644 (file)
@@ -588,10 +588,10 @@ struct pipe {
        IF_HAS_KEYWORDS(smallint res_word;) /* needed for if, for, while, until... */
 };
 typedef enum pipe_style {
-       PIPE_SEQ = 1,
-       PIPE_AND = 2,
-       PIPE_OR  = 3,
-       PIPE_BG  = 4,
+       PIPE_SEQ = 0,
+       PIPE_AND = 1,
+       PIPE_OR  = 2,
+       PIPE_BG  = 3,
 } pipe_style;
 /* Is there anything in this pipe at all? */
 #define IS_NULL_PIPE(pi) \
@@ -3139,7 +3139,6 @@ static struct pipe *new_pipe(void)
 {
        struct pipe *pi;
        pi = xzalloc(sizeof(struct pipe));
-       /*pi->followup = 0; - deliberately invalid value */
        /*pi->res_word = RES_NONE; - RES_NONE is 0 anyway */
        return pi;
 }