[Patch 2/4] Network rework: packet writing, sending and cleanups
authorLoic Blot <loic.blot@unix-experience.fr>
Fri, 16 Jan 2015 10:37:49 +0000 (11:37 +0100)
committerLoic Blot <loic.blot@unix-experience.fr>
Mon, 16 Feb 2015 10:00:55 +0000 (11:00 +0100)
commited04e8e9e407f0dd57fa83a9732b3a3968cb80e0
tree488c3b155e78072c0f65a26b8e34b530d059f56c
parentefa977518a60c47f3c409449be202298900372e8
[Patch 2/4] Network rework: packet writing, sending and cleanups

NetworkPacket.cpp:
* Remove some deprecated functions, we must use streaming interface
* m_data converted from u8* to std::vector<u8>
* Add an exporter to forge packet to Connection object
* implement operator << std::wstring. n
* implement operator << std::string
* dynamic resize when write packet content.
* fix string writing and performances.
* create ServerCommandFactory, used by client to get useful informations about packet processing (sending).
  * Reliability
  * Transmit channel
* Implement putRawString for some ugly char (_INIT packet), and use it.
* Many packet read and write migrated
* Implement oldForgePacket to interface writing with current connection
* fix U8/char/bool writing
* fix string writing and performances.
* add some missing functions
* Use v3s16 read instead of reading x,y,z separately
* Add irr::video::SColor support into packets
* Add some missing handlers
* Add a template function to increase offset
* Throw a serialization error on packet reading (must be improved)

PacketFactories:
* Create ServerCommandFactory, used by client to get useful informations about packet processing (sending).
* Create ClientCommandFactory, used by server to get useful informations about packet processing (sending).

Client.cpp:
* implement NetworkPacket ::Send interface.
* Move packet handlers to a dedicated file
* Remove Client::Send(SharedBuffer)

Server.cpp:
* implement NetworkPacket ::Send interface.
* Rewrite all packets using NetworkPacket
* Move packet handlers to a dedicated file
* Remove Server::Send(SharedBuffer)

ClientIface.cpp:
* Remove sendToAll(SharedBuffer<u8>)

Connection.hpp rework:
* Remove duplicate include
* Remove duplicate negation
* Remove a useless variable
* Improve code performance by using a m_peers_list instead of scanning m_peers map
* Remove Connection::Send(SharedBuffer)
* Fix useafterfree into NetworkPacket Sending
* Remove unused Connection::sendToAll

Test.cpp:
* Remove dead code
* Update tests to use NetworkPackets

Misc:
* add new wrappers to Send packets in client, using NetworkPacket
* Add NetworkPacket methods for Connection
* coding style fix
* dead code since changes cleanup
* Use v3s16 read instead of reading x,y,z separately in some packets
* Use different files to handle packets received by client and server
* Cleanup: Remove useless includes

ok @Zeno-
Tested by @Zeno- @VanessaE and @nerzhul on running servers
24 files changed:
src/CMakeLists.txt
src/client.cpp
src/client.h
src/clientiface.cpp
src/clientiface.h
src/connection.cpp [deleted file]
src/connection.h [deleted file]
src/network/clientopcodes.cpp
src/network/clientopcodes.h
src/network/connection.cpp [new file with mode: 0644]
src/network/connection.h [new file with mode: 0644]
src/network/networkpacket.cpp
src/network/networkpacket.h
src/network/packethandlers/client.cpp [new file with mode: 0644]
src/network/packethandlers/server.cpp [new file with mode: 0644]
src/network/serveropcodes.cpp
src/network/serveropcodes.h
src/network/toclientpacket.cpp [deleted file]
src/network/toclientpacket.h [deleted file]
src/network/toserverpacket.cpp [deleted file]
src/network/toserverpacket.h [deleted file]
src/server.cpp
src/server.h
src/test.cpp