Don't write the tick_identity to the session
authorMatt Caswell <matt@openssl.org>
Fri, 1 Mar 2019 15:40:20 +0000 (15:40 +0000)
committerMatt Caswell <matt@openssl.org>
Tue, 5 Mar 2019 14:28:27 +0000 (14:28 +0000)
commitc9a826d28f8211e86b3b866809e1b30a2de48740
treee9fb567553d4ad67191b204dc8d218edbd8d77c3
parent99f0c7a8a6999e2f78fc065e4da78643ae14c14c
Don't write the tick_identity to the session

Sessions must be immutable once they can be shared with multiple threads.
We were breaking that rule by writing the ticket index into it during the
handshake. This can lead to incorrect behaviour, including failed
connections in multi-threaded environments.

Reported by David Benjamin.

Reviewed-by: Paul Dale <paul.dale@oracle.com>
(Merged from https://github.com/openssl/openssl/pull/8383)

(cherry picked from commit c96ce52ce293785b54a42d119c457aef739cc2ce)
ssl/ssl_locl.h
ssl/statem/extensions.c
ssl/statem/extensions_clnt.c
ssl/statem/extensions_srvr.c
ssl/statem/statem_clnt.c