Address some -Wold-style-declaration warnings
authorBenjamin Kaduk <bkaduk@akamai.com>
Fri, 14 Apr 2017 16:53:04 +0000 (11:53 -0500)
committerRich Salz <rsalz@openssl.org>
Tue, 20 Jun 2017 17:35:33 +0000 (13:35 -0400)
commitbd97dde41e96193aa076260fb0057e9ce0f6861b
tree10aaf85ec777ee5eeb31bfe51bcf1aa63a46c6f5
parent725f121dcfc31d016fa23bfffde1b6342659949e
Address some -Wold-style-declaration warnings

gcc's -Wextra pulls in -Wold-style-declaration, which triggers when a
declaration has a storage-class specifier as a non-initial qualifier.
The ISO C formal grammar requires the storage-class to be the first
component of the declaration, if present.

Seeint as the register storage-class specifier does not really have any effect
anymore with modern compilers, remove it entirely while we're here, instead of
fixing up the order.

Interestingly, the gcc devteam warnings do not pull in -Wextra, though
the clang ones do.

[extended tests]

Reviewed-by: Andy Polyakov <appro@openssl.org>
Reviewed-by: Rich Salz <rsalz@openssl.org>
(Merged from https://github.com/openssl/openssl/pull/3239)
(cherry picked from commit f44903a428cc63ce88bfba26e8e4e2e9b21f058d)
crypto/cast/c_enc.c
crypto/ec/ecp_nistz256.c
crypto/include/internal/bn_dh.h
crypto/o_str.c