Fix various points reported by cppcheck (#5656)
authorLoïc Blot <nerzhul@users.noreply.github.com>
Tue, 25 Apr 2017 08:17:53 +0000 (10:17 +0200)
committerLoïc Blot <loic.blot@unix-experience.fr>
Tue, 25 Apr 2017 08:21:42 +0000 (10:21 +0200)
commita7e131f53e211ffbe38d34d23b33e13cc401f013
treec615160a94df851752d62bfc2a4cf9f4d01f63ab
parentaf9630962134346750f12c9f1856eae00e0dfe02
Fix various points reported by cppcheck (#5656)

* Fix various performance issues reported by cppcheck + code style (CI)

* Make CI happy with code style on master
* guiFileSelectMenu: remove useless includes
* some performance fixes pointed by cppcheck
* remove some useless casts
* TextDest: remove unused setFormSpec function

* Fix various iterator post-increment reported by cppcheck
13 files changed:
src/game.cpp
src/guiFormSpecMenu.h
src/map_settings_manager.cpp
src/nodedef.cpp
src/script/cpp_api/s_async.cpp
src/script/cpp_api/s_node.cpp
src/script/lua_api/l_client.cpp
src/script/lua_api/l_craft.cpp
src/script/lua_api/l_env.cpp
src/script/lua_api/l_mainmenu.cpp
src/script/lua_api/l_nodemeta.cpp
src/script/lua_api/l_server.cpp
src/util/thread.h