projects / oweals / openssl.git / commit
? search:
summary | shortlog | log | commit | commitdiff | tree
(parent: 9cabf6b) | patch
bignum: fix boundary condition in montgomery logic
authorGeoff Thorpe <geoff@openssl.org>
Wed, 30 Apr 2014 15:39:24 +0000 (11:39 -0400)
committerGeoff Thorpe <geoff@openssl.org>
Wed, 30 Apr 2014 15:49:31 +0000 (11:49 -0400)
commita52926189155d906d8c11ff97cbc1e5191d202cd
tree3afdb2399a90409ecf6212cd5e0c57e878eec604tree | snapshot
parent9cabf6bb802b705d6bbbc9525a03e922a58d5d5bcommit | diff
bignum: fix boundary condition in montgomery logic

It's not clear whether this inconsistency could lead to an actual
computation error, but it involved a BIGNUM being passed around the
montgomery logic in an inconsistent state. This was found using flags
-DBN_DEBUG -DBN_DEBUG_RAND, and working backwards from this assertion
in 'ectest';

ectest: bn_mul.c:960: BN_mul: Assertion `(_bnum2->top == 0) ||
(_bnum2->d[_bnum2->top - 1] != 0)' failed

Signed-off-by: Geoff Thorpe <geoff@openssl.org>
crypto/bn/bn_exp.c diff | blob | history
Unnamed repository; edit this file 'description' to name the repository.