zcip: fix link-local IP conflict detection
authorKen Sharp <ken.sharp@ni.com>
Sun, 20 Jul 2014 12:01:49 +0000 (14:01 +0200)
committerDenys Vlasenko <vda.linux@googlemail.com>
Sun, 20 Jul 2014 12:01:49 +0000 (14:01 +0200)
commita4d564ad7c24df2da1d8e03a7dd016f0a3d5edbd
treeeb814c511e7325f9f258e9a70bfef6385b3deadc
parentb8ffd11e65734f90ebdaedb0ce32196fb150db01
zcip: fix link-local IP conflict detection

During link-local IP resolution, if a regular ARP request is received
during the ARP probe period, it will incorrectly cause a target IP
conflict.  This then leads to a new IP being picked unnecessarily.

Per RFC 3927, section 2.2.1, we should flag a target IP conflict only if
the source IP is null, the target IP matches our IP, and the source
hw addr does not match our hw addr.

function                                             old     new   delta
zcip_main                                           1354    1322     -32

Signed-off-by: Ken Sharp <ken.sharp@ni.com>
Signed-off-by: Ben Shelton <ben.shelton@ni.com>
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
networking/zcip.c